Skip to content

Action Builder JSX cleanup #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Action Builder JSX cleanup #60

wants to merge 8 commits into from

Conversation

@anaxite
Copy link
Contributor

@anaxite anaxite commented Feb 24, 2025

This is a cleanup pass on the Action Builder's JSX components using Biome.

  • Applies some recommended fixes for legibility:
    • noUnusedTemplateLiteral
    • noForEach
    • useOptionalChain
    • noUselessElse
  • Runs the formatter on the components
  • Rearranges imports by import distance
  • Removes unnecessary React declarations

I used space indents, two spaces, to match most of the code so far.

@anaxite
Biome fix for lint/style/noUnusedTemplateLiteral:
a473c3d 
Do not use template literals if interpolation and special-character handling are not needed.
@anaxite
Biome fix for lint/complexity/noForEach:
4cfdbf8 
Prefer for...of instead of forEach. Improves readability and may improve some performance issues.
@anaxite
Biome fix for lint/style/noUnusedTemplateLiteral:
3a62c4d 
Do not use template literals if interpolation and special-character handling are not needed.
@anaxite
Biome fix for lint/complexity/useOptionalChain:
d24be79 
Change to an optional chain for conciceness and safe property access.
@anaxite
Biome fix for lint/style/noUselessElse:
47f5b71 
Remove redundant else statements. Their content will never be executed in conjuction with the if block.
@anaxite
Format JS/JSX/CSS with Biome
cf864d7 
Some line rearranging
Import sorting
Add/remove characters as needed
@anaxite
Remove unnecessary imports
b4c5f3e 
`import React` is apparently unnecessary since React 17
@anaxite
Re-run formatter to use the same indentation settings as the origin
f130047
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@anaxite