Skip to content

Increase ditamap recursion depth limit from 10 to 20#89

Closed
Copilot wants to merge 1 commit intorelative-dita-processingfrom
copilot/sub-pr-88
Closed

Increase ditamap recursion depth limit from 10 to 20#89
Copilot wants to merge 1 commit intorelative-dita-processingfrom
copilot/sub-pr-88

Conversation

Copy link
Contributor

Copilot AI commented Nov 27, 2025

CI was failing with Maximum recursion depth (10) exceeded while parsing ditamap for deeply nested DITA maps.

Changes

  • src/utils.js: Bumped default maxDepth from 10 to 20 in parseDitamap()
  • src/utils.test.js: Updated recursion test to use explicit maxDepth=5 parameter rather than relying on default—faster execution, same coverage
// Before
function parseDitamap(ditamapPath, visitedMaps = new Set(), depth = 0, maxDepth = 10)

// After
function parseDitamap(ditamapPath, visitedMaps = new Set(), depth = 0, maxDepth = 20)

Note: The .gitmodules error in CI (No url found for submodule path 'local-llm/llama.cpp') is unrelated—no .gitmodules file exists in this repository.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 27, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI changed the title [WIP] Fix baseline relative DITA resolution issues Increase ditamap recursion depth limit from 10 to 20 Nov 27, 2025
Copilot AI requested a review from hawkeyexl November 27, 2025 06:53
@hawkeyexl
Copy link
Contributor

Copilot failed to commit. Closing.

@hawkeyexl hawkeyexl closed this Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants