This repository was archived by the owner on Aug 9, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Fix encoding error #63
Open
cary-hu
wants to merge
5
commits into
docascode:develop
Choose a base branch
from
cary-hu:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,7 @@ | |
| <apache.commons-collections.version>4.2</apache.commons-collections.version> | ||
| <apache.commons-io.version>2.6</apache.commons-io.version> | ||
| <apache.commons-text.version>1.9</apache.commons-text.version> | ||
| <remark.version>1.1.0</remark.version> | ||
| <remark.version>1.2.0</remark.version> | ||
| </properties> | ||
|
|
||
| <build> | ||
|
|
@@ -127,8 +127,9 @@ | |
| <artifactId>jackson-dataformat-yaml</artifactId> | ||
| <version>${jackson.version}</version> | ||
| </dependency> | ||
| <!-- https://mvnrepository.com/artifact/com.kotcrab.remark/remark --> | ||
| <dependency> | ||
| <groupId>com.overzealous</groupId> | ||
| <groupId>com.kotcrab.remark</groupId> | ||
| <artifactId>remark</artifactId> | ||
| <version>${remark.version}</version> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. May be it's reasonable to use existing constant remark.version (with 1.2.0 value) or remove it from properties |
||
| </dependency> | ||
|
|
@@ -157,7 +158,7 @@ | |
|
|
||
| <repositories> | ||
| <repository> | ||
| <id>sprin-libs-repo</id> | ||
| <id>spring-libs-repo</id> | ||
| <name>Spring Lib Release repository</name> | ||
| <url>https://repo.spring.io/libs-release</url> | ||
| </repository> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| package com.microsoft.samples.noneascii; | ||
|
|
||
|
|
||
| import java.net.URI; | ||
| import java.util.List; | ||
|
|
||
| /** | ||
| * 代表客户可用的产品形式 | ||
| */ | ||
| public class Offer | ||
| { | ||
| /** | ||
| * 初始化Offer类的新实例。 | ||
| */ | ||
| public Offer() | ||
| { | ||
| } | ||
|
|
||
| /** | ||
| * 获取或设置合作伙伴要求的资格,以便为客户购买优惠。 | ||
| */ | ||
| private String[] __ResellerQualifications; | ||
|
|
||
| public String[] getResellerQualifications() | ||
| { | ||
| return __ResellerQualifications; | ||
| } | ||
|
|
||
| public void setResellerQualifications(String[] value) | ||
| { | ||
| __ResellerQualifications = value; | ||
| } | ||
|
|
||
| /** | ||
| * 获取或设置客户要求合作伙伴为客户购买的资格。 | ||
| */ | ||
| private String[] __ReselleeQualifications; | ||
|
|
||
| public String[] getReselleeQualifications() | ||
| { | ||
| return __ReselleeQualifications; | ||
| } | ||
|
|
||
| public void setReselleeQualifications(String[] value) | ||
| { | ||
| __ReselleeQualifications = value; | ||
| } | ||
| } |
15 changes: 15 additions & 0 deletions
15
src/test/resources/expected-generated-files/com.microsoft.samples.noneascii.Offer.Offer.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| ### YamlMime:JavaMember | ||
| uid: "com.microsoft.samples.noneascii.Offer.Offer*" | ||
| fullName: "com.microsoft.samples.noneascii.Offer.Offer" | ||
| name: "Offer" | ||
| nameWithType: "Offer.Offer" | ||
| members: | ||
| - uid: "com.microsoft.samples.noneascii.Offer.Offer()" | ||
| fullName: "com.microsoft.samples.noneascii.Offer.Offer()" | ||
| name: "Offer()" | ||
| nameWithType: "Offer.Offer()" | ||
| summary: "初始化Offer类的新实例。" | ||
| syntax: "public Offer()" | ||
| type: "constructor" | ||
| metadata: {} | ||
| package: "com.microsoft.samples.noneascii" |
16 changes: 16 additions & 0 deletions
16
...ected-generated-files/com.microsoft.samples.noneascii.Offer.getReselleeQualifications.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| ### YamlMime:JavaMember | ||
| uid: "com.microsoft.samples.noneascii.Offer.getReselleeQualifications*" | ||
| fullName: "com.microsoft.samples.noneascii.Offer.getReselleeQualifications" | ||
| name: "getReselleeQualifications" | ||
| nameWithType: "Offer.getReselleeQualifications" | ||
| members: | ||
| - uid: "com.microsoft.samples.noneascii.Offer.getReselleeQualifications()" | ||
| fullName: "com.microsoft.samples.noneascii.Offer.getReselleeQualifications()" | ||
| name: "getReselleeQualifications()" | ||
| nameWithType: "Offer.getReselleeQualifications()" | ||
| syntax: "public String[] getReselleeQualifications()" | ||
| returns: | ||
| type: "<xref href=\"java.lang.String?alt=java.lang.String&text=String\" data-throw-if-not-resolved=\"False\" />[]" | ||
| type: "method" | ||
| metadata: {} | ||
| package: "com.microsoft.samples.noneascii" |
16 changes: 16 additions & 0 deletions
16
...ected-generated-files/com.microsoft.samples.noneascii.Offer.getResellerQualifications.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| ### YamlMime:JavaMember | ||
| uid: "com.microsoft.samples.noneascii.Offer.getResellerQualifications*" | ||
| fullName: "com.microsoft.samples.noneascii.Offer.getResellerQualifications" | ||
| name: "getResellerQualifications" | ||
| nameWithType: "Offer.getResellerQualifications" | ||
| members: | ||
| - uid: "com.microsoft.samples.noneascii.Offer.getResellerQualifications()" | ||
| fullName: "com.microsoft.samples.noneascii.Offer.getResellerQualifications()" | ||
| name: "getResellerQualifications()" | ||
| nameWithType: "Offer.getResellerQualifications()" | ||
| syntax: "public String[] getResellerQualifications()" | ||
| returns: | ||
| type: "<xref href=\"java.lang.String?alt=java.lang.String&text=String\" data-throw-if-not-resolved=\"False\" />[]" | ||
| type: "method" | ||
| metadata: {} | ||
| package: "com.microsoft.samples.noneascii" |
17 changes: 17 additions & 0 deletions
17
...ected-generated-files/com.microsoft.samples.noneascii.Offer.setReselleeQualifications.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| ### YamlMime:JavaMember | ||
| uid: "com.microsoft.samples.noneascii.Offer.setReselleeQualifications*" | ||
| fullName: "com.microsoft.samples.noneascii.Offer.setReselleeQualifications" | ||
| name: "setReselleeQualifications" | ||
| nameWithType: "Offer.setReselleeQualifications" | ||
| members: | ||
| - uid: "com.microsoft.samples.noneascii.Offer.setReselleeQualifications(java.lang.String[])" | ||
| fullName: "com.microsoft.samples.noneascii.Offer.setReselleeQualifications(String[] value)" | ||
| name: "setReselleeQualifications(String[] value)" | ||
| nameWithType: "Offer.setReselleeQualifications(String[] value)" | ||
| parameters: | ||
| - name: "value" | ||
| type: "<xref href=\"java.lang.String?alt=java.lang.String&text=String\" data-throw-if-not-resolved=\"False\" />[]" | ||
| syntax: "public void setReselleeQualifications(String[] value)" | ||
| type: "method" | ||
| metadata: {} | ||
| package: "com.microsoft.samples.noneascii" |
17 changes: 17 additions & 0 deletions
17
...ected-generated-files/com.microsoft.samples.noneascii.Offer.setResellerQualifications.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| ### YamlMime:JavaMember | ||
| uid: "com.microsoft.samples.noneascii.Offer.setResellerQualifications*" | ||
| fullName: "com.microsoft.samples.noneascii.Offer.setResellerQualifications" | ||
| name: "setResellerQualifications" | ||
| nameWithType: "Offer.setResellerQualifications" | ||
| members: | ||
| - uid: "com.microsoft.samples.noneascii.Offer.setResellerQualifications(java.lang.String[])" | ||
| fullName: "com.microsoft.samples.noneascii.Offer.setResellerQualifications(String[] value)" | ||
| name: "setResellerQualifications(String[] value)" | ||
| nameWithType: "Offer.setResellerQualifications(String[] value)" | ||
| parameters: | ||
| - name: "value" | ||
| type: "<xref href=\"java.lang.String?alt=java.lang.String&text=String\" data-throw-if-not-resolved=\"False\" />[]" | ||
| syntax: "public void setResellerQualifications(String[] value)" | ||
| type: "method" | ||
| metadata: {} | ||
| package: "com.microsoft.samples.noneascii" |
31 changes: 31 additions & 0 deletions
31
src/test/resources/expected-generated-files/com.microsoft.samples.noneascii.Offer.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| ### YamlMime:JavaType | ||
| uid: "com.microsoft.samples.noneascii.Offer" | ||
| fullName: "com.microsoft.samples.noneascii.Offer" | ||
| name: "Offer" | ||
| nameWithType: "Offer" | ||
| summary: "代表客户可用的产品形式" | ||
| inheritances: | ||
| - "<xref href=\"java.lang.Object\" data-throw-if-not-resolved=\"False\" />" | ||
| inheritedMembers: | ||
| - "java.lang.Object.clone()" | ||
| - "java.lang.Object.equals(java.lang.Object)" | ||
| - "java.lang.Object.finalize()" | ||
| - "java.lang.Object.getClass()" | ||
| - "java.lang.Object.hashCode()" | ||
| - "java.lang.Object.notify()" | ||
| - "java.lang.Object.notifyAll()" | ||
| - "java.lang.Object.toString()" | ||
| - "java.lang.Object.wait()" | ||
| - "java.lang.Object.wait(long)" | ||
| - "java.lang.Object.wait(long,int)" | ||
| syntax: "public class Offer" | ||
| constructors: | ||
| - "com.microsoft.samples.noneascii.Offer.Offer()" | ||
| methods: | ||
| - "com.microsoft.samples.noneascii.Offer.getReselleeQualifications()" | ||
| - "com.microsoft.samples.noneascii.Offer.getResellerQualifications()" | ||
| - "com.microsoft.samples.noneascii.Offer.setReselleeQualifications(java.lang.String[])" | ||
| - "com.microsoft.samples.noneascii.Offer.setResellerQualifications(java.lang.String[])" | ||
| type: "class" | ||
| metadata: {} | ||
| package: "com.microsoft.samples.noneascii" |
8 changes: 8 additions & 0 deletions
8
src/test/resources/expected-generated-files/com.microsoft.samples.noneascii.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| ### YamlMime:JavaPackage | ||
| uid: "com.microsoft.samples.noneascii" | ||
| fullName: "com.microsoft.samples.noneascii" | ||
| name: "com.microsoft.samples.noneascii" | ||
| classes: | ||
| - "com.microsoft.samples.noneascii.Offer" | ||
| metadata: {} | ||
| package: "com.microsoft.samples.noneascii" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, seems original artifact was removed from repo, so we should replace it with possible fork.
And it's mandatory change for person who hasn't legacy com.overzealous artifact in local maven repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I see