Merge pull request #647 from glours/remove_app_status_command

remove the status command from docker app CLI

Author: silvin-lubecki

README.md

@@ -361,7 +361,6 @@ Commands:
   pull        Pull an application package from a registry
   push        Push an application package to a registry
   render      Render the Compose file for an Application Package
-  status      Get the installation status of an application
   rm          Remove an application
   upgrade     Upgrade an installed application
   validate    Checks the rendered application is syntactically correct

e2e/cnab_test.go

@@ -58,12 +58,6 @@ func TestCallCustomStatusAction(t *testing.T) {
 				cmd.Command = dockerCli.Command("app", "rm", testCase.name)
 				icmd.RunCmd(cmd).Assert(t, icmd.Success)
 			}()
-
-			// docker app status
-			cmd.Command = dockerCli.Command("app", "status", testCase.name)
-			result := icmd.RunCmd(cmd)
-			result.Assert(t, icmd.Expected{ExitCode: testCase.exitCode})
-			assert.Assert(t, is.Contains(result.Combined(), testCase.expectedOutput))
 		})
 	}
 }

e2e/commands_test.go

@@ -314,39 +314,6 @@ func testDockerAppLifecycle(t *testing.T, useBindMount bool) {
 			fmt.Sprintf("Creating service %s_web", appName),
 		})
 
-	// Query the application status
-	cmd.Command = dockerCli.Command("app", "status", appName)
-	checkContains(t, icmd.RunCmd(cmd).Assert(t, icmd.Success).Combined(),
-		[]string{
-			`INSTALLATION
-------------
-Name:         TestDockerAppLifecycle_.*
-Created:      .*
-Modified:     .*
-Revision:     .*
-Last Action:  install
-Result:       SUCCESS
-Orchestrator: swarm
-
-APPLICATION
------------
-Name:      simple
-Version:   1.1.0-beta1
-Reference:.*
-
-PARAMETERS
-----------
-api_host:      example.com
-static_subdir: data/static
-web_port:      8082
-
-STATUS
-------`,
-			fmt.Sprintf("[[:alnum:]]+        %s_db    replicated          [0-1]/1                 postgres:9.3", appName),
-			fmt.Sprintf(`[[:alnum:]]+        %s_web   replicated          [0-1]/1                 nginx:latest        \*:8082->80/tcp`, appName),
-			fmt.Sprintf("[[:alnum:]]+        %s_api   replicated          [0-1]/1                 python:3.6", appName),
-		})
-
 	// List the installed application
 	cmd.Command = dockerCli.Command("app", "ls")
 	checkContains(t, icmd.RunCmd(cmd).Assert(t, icmd.Success).Combined(),
@@ -371,10 +338,6 @@ STATUS
 			fmt.Sprintf("Updating service %s_web", appName),
 		})
 
-	// Query the application status again, the port should have change
-	cmd.Command = dockerCli.Command("app", "status", appName)
-	icmd.RunCmd(cmd).Assert(t, icmd.Expected{ExitCode: 0, Out: "8081"})
-
 	// Uninstall the application
 	cmd.Command = dockerCli.Command("app", "rm", appName)
 	checkContains(t, icmd.RunCmd(cmd).Assert(t, icmd.Success).Combined(),

e2e/testdata/plugin-usage-experimental.golden

@@ -19,7 +19,6 @@ Commands:
   push        Push an application package to a registry
   render      Render the Compose file for an Application Package
   rm          Remove an application
-  status      Get the installation status of an application
   upgrade     Upgrade an installed application
   validate    Checks the rendered application is syntactically correct
 

e2e/testdata/plugin-usage.golden

@@ -19,7 +19,6 @@ Commands:
   push        Push an application package to a registry
   render      Render the Compose file for an Application Package
   rm          Remove an application
-  status      Get the installation status of an application
   upgrade     Upgrade an installed application
   validate    Checks the rendered application is syntactically correct
 

examples/cnab-helm/README.md

@@ -32,29 +32,6 @@ Application "hellohelm" installed on context "default"
 **Note**: When using Docker Desktop, you will need to change the IP address in
 your Kubernetes configuration file from `127.0.0.1` to its internal IP address.
 
-Check the status of the Helm-based application:
-
-```console
-$ docker app status --credential-set creds.yaml hellohelm
-INSTALLATION
-------------
-Name:        hellohelm
-Created:     39 seconds
-Modified:    36 seconds
-Revision:    01DD3JM99WRGVAV7T56RMAW13E
-Last Action: install
-Result:      SUCCESS
-
-APPLICATION
------------
-Name:      hellohelm
-Version:   0.1.0
-Reference:
-
-PARAMETERS
-----------
-port: 8080
-```
 
 Uninstall the Helm-based application:
 

examples/cnab-simple/README.md

@@ -33,12 +33,6 @@ Install the application:
 $ docker app install
 ```
 
-Show the details of the installation:
-
-```console
-$ docker app status hello
-```
-
 Upgrade the installation, demonstrating setting parameters:
 
 ```console

internal/commands/root.go

@@ -70,7 +70,6 @@ func addCommands(cmd *cobra.Command, dockerCli command.Cli) {
 		upgradeCmd(dockerCli),
 		removeCmd(dockerCli),
 		listCmd(dockerCli),
-		statusCmd(dockerCli),
 		initCmd(dockerCli),
 		inspectCmd(dockerCli),
 		renderCmd(dockerCli),