eclipse-mosquitto: Update license and improve documentation #2498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianon
reviewed
Oct 21, 2024
Member
tianon
left a comment
tianon
left a comment
There was a problem hiding this comment.
I left a few comments -- notably, $(pwd) shells out unnecessarily: the shell maintains $PWD automatically 😄
eclipse-mosquitto/content.md
Outdated
|
|
||
| ```console | ||
| $ docker run -it -p 1883:1883 -p 9001:9001 -v mosquitto.conf:/mosquitto/config/mosquitto.conf %%IMAGE%% | ||
| $ docker run -it -p 1883:1883 -v $(pwd)/mosquitto/config:/mosquitto/config %%IMAGE%% |
Member
There was a problem hiding this comment.
Suggested change
| $ docker run -it -p 1883:1883 -v $(pwd)/mosquitto/config:/mosquitto/config %%IMAGE%% | |
| $ docker run -it -p 1883:1883 -v "$PWD/mosquitto/config:/mosquitto/config" %%IMAGE%% |
eclipse-mosquitto/content.md
Outdated
|
|
||
| ```console | ||
| $ docker run -it -p 1883:1883 -p 9001:9001 -v mosquitto.conf:/mosquitto/config/mosquitto.conf -v /mosquitto/data -v /mosquitto/log %%IMAGE%% | ||
| $ docker run -it -p 1883:1883 -v $(pwd)/mosquitto/config:/mosquitto/config -v /mosquitto/data -v /mosquitto/log %%IMAGE%% |
Member
There was a problem hiding this comment.
Suggested change
| $ docker run -it -p 1883:1883 -v $(pwd)/mosquitto/config:/mosquitto/config -v /mosquitto/data -v /mosquitto/log %%IMAGE%% | |
| $ docker run -it -p 1883:1883 -v "$PWD/mosquitto/config:/mosquitto/config" -v /mosquitto/data -v /mosquitto/log %%IMAGE%% |
eclipse-mosquitto/content.md
Outdated
| or: | ||
|
|
||
| ```console | ||
| $ docker run -it -p 1883:1883 -v $(pwd)/mosquitto/config:/mosquitto/config -v $(pwd)/mosquitto/data:/mosquitto/data -v $(pwd)/mosquitto/log:/mosquitto/log %%IMAGE%% |
Member
There was a problem hiding this comment.
Suggested change
| $ docker run -it -p 1883:1883 -v $(pwd)/mosquitto/config:/mosquitto/config -v $(pwd)/mosquitto/data:/mosquitto/data -v $(pwd)/mosquitto/log:/mosquitto/log %%IMAGE%% | |
| $ docker run -it -p 1883:1883 -v "$PWD/mosquitto/config:/mosquitto/config" -v "$PWD/mosquitto/data:/mosquitto/data" -v "$PWD/mosquitto/log:/mosquitto/log" %%IMAGE%% |
eclipse-mosquitto/content.md
Outdated
| ## Configuration | ||
|
|
||
| When running the image, the default configuration values are used. To use a custom configuration file, mount a **local** configuration file to `/mosquitto/config/mosquitto.conf` | ||
| When running the image, the default configuration values are used. To use a custom configuration file, create your mosquitto.conf in `$(pwd)/mosquitto/config/mosquitto.conf`, then mount the config directory to `/mosquitto/config`. |
Member
There was a problem hiding this comment.
Suggested change
| When running the image, the default configuration values are used. To use a custom configuration file, create your mosquitto.conf in `$(pwd)/mosquitto/config/mosquitto.conf`, then mount the config directory to `/mosquitto/config`. | |
| When running the image, the default configuration values are used. To use a custom configuration file, create your mosquitto.conf in `$PWD/mosquitto/config/mosquitto.conf`, then mount the config directory to `/mosquitto/config`. |
eclipse-mosquitto/content.md
Outdated
| For example, if you use port 1883 and port 8080: | ||
|
|
||
| ```console | ||
| $ docker run -it -p 1883:1883 -p 8080:8080 -v $(pwd)/mosquitto/config:/mosquitto/config %%IMAGE%% |
Member
There was a problem hiding this comment.
Suggested change
| $ docker run -it -p 1883:1883 -p 8080:8080 -v $(pwd)/mosquitto/config:/mosquitto/config %%IMAGE%% | |
| $ docker run -it -p 1883:1883 -p 8080:8080 -v "$PWD/mosquitto/config:/mosquitto/config" %%IMAGE%% |
ralight
force-pushed
the
eclipse-mosquitto-docs
branch
from
5a9d4a2 to
aa625c5
Compare
ralight
force-pushed
the
eclipse-mosquitto-docs
branch
from
aa625c5 to
2bf3f35
Compare
Contributor
Author
Thanks, that's bad habit of mine :) |
tianon
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.