Run upstream tests on images in CI here#555
Run upstream tests on images in CI here#555tianon wants to merge 1 commit intodocker-library:masterfrom
Conversation
|
Ouch, I knew they'd be rough, but 10-11 minutes is even heavier than I was picturing. |
|
On the upside, total "wall clock" for https://github.com/docker-library/golang/actions/runs/13339366508 (current master) is ~23m 56s and https://github.com/docker-library/golang/actions/runs/13338265228 (this PR) is ~30m 36s. |
|
I agree to adding tests to ensure that the go binaries work as expected in the container environment but the comparison to the most recent run on master is not quite accurate since it took so long because of the Windows 2025 failures ( I think the biggest extra slowdown is the serial testing of |
.test/tests/go-dist-test/run.sh
Outdated
| # the "dist" tool doesn't query Go for GOROOT and expects it to be set explicitly | ||
| sh -xec 'GOROOT="$(go env GOROOT)" && export GOROOT && exec "$@"' -- | ||
|
|
||
| # ideally this would just be "go tool dist test" but it isn't built by default (because most users don't need it) |
There was a problem hiding this comment.
Oh neat, this gets better in 1.25+: https://go.dev/doc/go1.25#go-command
The Go distribution will include fewer prebuilt tool binaries. Core toolchain binaries such as the compiler and linker will still be included, but tools not invoked by build or test operations will be built and run by go tool as needed.
(go tool dist test "just works" in 1.25+)
This runs upstream's `dist test` which is roughly `go test std cmd`.
|
"Build: 20s, Test: 15.5m" does not feel good - I'm very torn here. I think this is valuable, but it's way too heavy. |
This runs upstream's
dist testwhich is roughlygo test std cmd.Fixes #552