Open
Conversation
|
|
||
| _cli() { | ||
| docker exec -u www-data "$cid" php installation/joomla.php install -n \ | ||
| --site-name="test-$RANDOM" \ |
There was a problem hiding this comment.
Typically I advise against using random variables in unit tests - you want them to be perfectly replicable on each run
Member
There was a problem hiding this comment.
In these tests, we encourage random variance because it usually increases the chances that the test is actually testing something meaningful instead of just hitting the happy path every time (for example, putting a "default" value in the test that just happens to work because it matches the default of the image when the image wouldn't handle a non-default value, for example).
Member
|
Since most of the test have the same setup logic, it might be desirable to convert them to use bash functions with parameters for the varying parts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix joomla-docker/docker-joomla#47