Skip to content

Remove opcache from php-ext-install #19628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025
Merged

Remove opcache from php-ext-install #19628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions test/tests/php-ext-install/container.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,4 @@ docker-php-ext-install pdo_mysql 2>&1
php -d display_errors=stderr -r 'exit(extension_loaded("pdo_mysql") ? 0 : 1);'
grep -q '^extension=' /usr/local/etc/php/conf.d/*pdo_mysql*.ini

# opcache is pre-built by default at least as far back as PHP 5.5
docker-php-ext-enable opcache 2>&1
php -d display_errors=stderr -r 'exit(extension_loaded("Zend OPcache") ? 0 : 1);'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test can stay - https://3v4l.org/auMnl/rfc#vgit.master, it only does not have to/can be enabled manually/explicitly

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice, but it's the docker-php-ext-enable opcache bit that this was actually important for (making sure that switched from extension= to zend_extension= transparently), and that broke. In hindsight, it looks like we could've maybe swapped to docker-php-ext-install opcache instead, but that fails like this in PHP 8.5.0beta1:

Installing shared extensions:     /usr/local/lib/php/extensions/no-debug-non-zts-20240925/
cp: cannot stat 'modules/*': No such file or directory
make: *** [Makefile:89: install-modules] Error 1

grep -q '^zend_extension=' /usr/local/etc/php/conf.d/*opcache*.ini
# TODO now that opcache is built-in (8.5+), we could use a new zend_extension to test that they're loaded correctly too 🙈
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To this point, there's something in there called zend_test, but it requires libxml to compile so I didn't want to completely refactor this test just so we keep testing loading zend_extensions, especially since they're so rare.

Loading