-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add "zstd" library during build to support "zstd" module in stdlib #1086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
gnupg \ | ||
tar \ | ||
xz \ | ||
\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yosifkit this part of the diff is because I went a little bit overboard to add support for "build-time-only" deps in non-slim Debian variants - I'm happy to refactor further if you'd like to avoid pushing these down into the list below 👍
(if we deal with docker-library/official-images#20054 first, we can close/reopen this and kick off a manual build on master to see it actually tested both directions) |
You can see the expected, failing tests in https://github.com/docker-library/python/actions/runs/18357122459 Traceback (most recent call last):
File "/tmp/test-dir/python-imports/./container.py", line 29, in <module>
from compression import zstd
File "/usr/local/lib/python3.14/compression/zstd/__init__.py", line 29, in <module>
import _zstd
ModuleNotFoundError: No module named '_zstd'
'python-imports' [4/8]...failed |
Oh, apparently non-slim didn't technically need this: #9 1.305 + apt-get install -y --no-install-recommends libzstd-dev
#9 1.312 Reading package lists...
#9 1.753 Building dependency tree...
#9 1.858 Reading state information...
#9 2.010 libzstd-dev is already the newest version (1.5.7+dfsg-1).
#9 2.010 libzstd-dev set to manually installed.
#9 2.010 0 upgraded, 0 newly installed, 0 to remove and 4 not upgraded. However, it's not explicitly part of |
Changes: - docker-library/python@2074a85e: Merge pull request docker-library/python#1086 from infosiftr/zstd - docker-library/python@54f31933: Merge pull request docker-library/python#1087 from infosiftr/s390x - docker-library/python@8545fffc: Add back s390x for 3.14+ - docker-library/python@a83345bc: Add "zstd" library during build to support "zstd" module in stdlib
Changes: - docker-library/python@2074a85e: Merge pull request docker-library/python#1086 from infosiftr/zstd - docker-library/python@54f31933: Merge pull request docker-library/python#1087 from infosiftr/s390x - docker-library/python@8545fffc: Add back s390x for 3.14+ - docker-library/python@a83345bc: Add "zstd" library during build to support "zstd" module in stdlib Co-authored-by: Docker Library Bot <[email protected]>
See https://docs.python.org/3.14/library/compression.zstd.html (new in 3.14+)