Skip to content

Conversation

tianon
Copy link
Member

@tianon tianon commented Oct 8, 2025

Comment on lines -31 to -34
gnupg \
tar \
xz \
\
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yosifkit this part of the diff is because I went a little bit overboard to add support for "build-time-only" deps in non-slim Debian variants - I'm happy to refactor further if you'd like to avoid pushing these down into the list below 👍

@tianon
Copy link
Member Author

tianon commented Oct 8, 2025

(if we deal with docker-library/official-images#20054 first, we can close/reopen this and kick off a manual build on master to see it actually tested both directions)

@yosifkit yosifkit closed this Oct 8, 2025
@yosifkit yosifkit reopened this Oct 8, 2025
@yosifkit
Copy link
Member

yosifkit commented Oct 8, 2025

You can see the expected, failing tests in https://github.com/docker-library/python/actions/runs/18357122459

Traceback (most recent call last):
  File "/tmp/test-dir/python-imports/./container.py", line 29, in <module>
    from compression import zstd
  File "/usr/local/lib/python3.14/compression/zstd/__init__.py", line 29, in <module>
    import _zstd
ModuleNotFoundError: No module named '_zstd'
	'python-imports' [4/8]...failed

@tianon tianon mentioned this pull request Oct 8, 2025
@tianon
Copy link
Member Author

tianon commented Oct 8, 2025

Oh, apparently non-slim didn't technically need this:

#9 1.305 + apt-get install -y --no-install-recommends libzstd-dev
#9 1.312 Reading package lists...
#9 1.753 Building dependency tree...
#9 1.858 Reading state information...
#9 2.010 libzstd-dev is already the newest version (1.5.7+dfsg-1).
#9 2.010 libzstd-dev set to manually installed.
#9 2.010 0 upgraded, 0 newly installed, 0 to remove and 4 not upgraded.

However, it's not explicitly part of buildpack-deps, only transitively, so I'm still convinced this is probably correct even though both blocks do ~nothing.

@yosifkit yosifkit merged commit 2074a85 into docker-library:master Oct 8, 2025
84 checks passed
@yosifkit yosifkit deleted the zstd branch October 8, 2025 20:53
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Oct 8, 2025
Changes:

- docker-library/python@2074a85e: Merge pull request docker-library/python#1086 from infosiftr/zstd
- docker-library/python@54f31933: Merge pull request docker-library/python#1087 from infosiftr/s390x
- docker-library/python@8545fffc: Add back s390x for 3.14+
- docker-library/python@a83345bc: Add "zstd" library during build to support "zstd" module in stdlib
tianon pushed a commit to docker-library/official-images that referenced this pull request Oct 8, 2025
Changes:

- docker-library/python@2074a85e: Merge pull request docker-library/python#1086 from infosiftr/zstd
- docker-library/python@54f31933: Merge pull request docker-library/python#1087 from infosiftr/s390x
- docker-library/python@8545fffc: Add back s390x for 3.14+
- docker-library/python@a83345bc: Add "zstd" library during build to support "zstd" module in stdlib

Co-authored-by: Docker Library Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No module named '_zstd'

2 participants