Skip to content

Clarify .dockerignore usage in README #1341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Clarify .dockerignore usage in README #1341

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b515073
Clarify .dockerignore in README
npwolf Mar 27, 2025
67fd940
Further .dockerignore clarification
npwolf Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ jobs:
```

Be careful because **any file mutation in the steps that precede the build step
will be ignored, including processing of the `.dockerignore` file** since
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is already self-explanatory that .dockerignore is ignored with Git context here. We also say that Path context should be used in next sentence if you don't want this behavior.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crazy-max I personally thought the text was saying file mutations in general and file mutations of the .dockerignore file specifically weren't supported with git context (not that .dockerignore wasn't supported at all in git context). I've updated this with another revision to try to improve the clarity for others. Let me know if I can improve it further. If you don't feel it warrants an update, feel free to close the PR. Thanks!

will be ignored. Additionally the `.dockerignore` file is not used and can only be utilized by using path context.** since
the context is based on the Git reference. However, you can use the
[Path context](#path-context) using the [`context` input](#inputs) alongside
the [`actions/checkout`](https://github.com/actions/checkout/) action to remove
Expand Down