[v0.10] Fix attestation overrides with duplicate types
#1700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Chadwell <[email protected]>
This ensures that `--sbom=<bool>` and `--attest type=sbom` can be appropriately merged for build, and `--sbom=<bool>` and `target.attest=["type=sbom"]` can be appropriately merged for bake. Signed-off-by: Justin Chadwell <[email protected]>
Signed-off-by: Justin Chadwell <[email protected]>
crazy-max
reviewed
Mar 28, 2023
| attestType = value | ||
| case "enabled": | ||
| enabled, err = strconv.ParseBool(value) | ||
| case "disabled": |
Member
There was a problem hiding this comment.
This change is fine by me, as you said it's internal. PTAL @tonistiigi.
crazy-max
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍒 Cherry-pick of #1699 - not a clean pick because of #1614.
This PR:
types #1699 (changes required because keys in the map are slightly different and haveattest:prefix).disabled(insteadenabled), which allows us to keep the same tests as in Fix attestation overrides with duplicatetypes #1699. This behavior is not a breaking change, since the value is entirely undocumented and internal - it should not be used by external users.types #1699, a different implementation is required because of changes to the function signature from controller: strongly type the controller api #1614.