-
Notifications
You must be signed in to change notification settings - Fork 617
monitor: Move commands to a separated package #1760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jedevc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of initial thoughts, haven't done a proper deep dive into the command implementations yet, will try and get to that tomorrow ❤️
|
Could you rebase onto master since #1737 merged? |
This commit moves monitor commands to `monior/commands` package. Commands still need access to the `monitor` object and buildx controller so this commit enables this via `Monitor` interface stored in `monitor/types`. Signed-off-by: Kohei Tokunaga <[email protected]>
Signed-off-by: Kohei Tokunaga <[email protected]>
Signed-off-by: Justin Chadwell <[email protected]>
jedevc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good now IMO 🎉
I think we can do some future tidy-ups, but this is a significant improvement from the big switch statement 🎉 🎉
Thanks!
Following-up #1640 (comment)
From @jedevc 's comment:
This commit moves monitor commands to
monior/commandspackage. Commands still need access to themonitorobject and buildx controller so this commit enables this viaMonitorinterface stored inmonitor/types.