debug: secondary client build should not reuse solve opts #1771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Chadwell <[email protected]>
jedevc
force-pushed
the
unset-other-build-client-opt
branch
from
aac9f1f to
e5a0ed1
Compare
crazy-max
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #1735 merged, each solve opt cannot be re-used. In this case, we don't actually need to re-use the whole solve opt, and can just use the empty one (as we used to before #1640).
Without this, invoke doesn't work, and processes will never actually start in the target container.
This problem goes away with something like #1750, but since that is still in draft, we can do a quick fixup in the meantime.