Skip to content

dap: ensure test client is closed on cleanup #3402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tonistiigi merged 1 commit into from
Sep 3, 2025
Merged

dap: ensure test client is closed on cleanup #3402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions dap/adapter_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ import (
)

func TestLaunch(t *testing.T) {
t.Skip("test fails with errgroup v0.16.0, that doesn't swallow panic in goroutine")

adapter, conn, client := NewTestAdapter[common.Config](t)

ctx, cancel := context.WithTimeoutCause(context.Background(), 10*time.Second, context.DeadlineExceeded)
Expand Down Expand Up @@ -83,14 +81,14 @@ func NewTestAdapter[C LaunchConfig](t *testing.T) (*Adapter[C], Conn, *Client) {
})

clientConn := logConn(t, "client", NewConn(rd2, wr1))
t.Cleanup(func() {
clientConn.Close()
})
t.Cleanup(func() { clientConn.Close() })

adapter := New[C]()
t.Cleanup(func() { adapter.Stop() })

client := NewClient(clientConn)
t.Cleanup(func() { client.Close() })

return adapter, srvConn, client
}

Expand Down