[v0.29] cherry-picks for v0.29.1#3449
Merged
crazy-max merged 2 commits intodocker:v0.29from Oct 3, 2025
Merged
Conversation
When creating index from singe-arch manifests it was possible for some of the internal manifests to not be copies and cause error on pushing the index. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
thompson-shaun
approved these changes
Oct 3, 2025
thaJeztah
reviewed
Oct 3, 2025
Comment on lines
224
to
+225
| ctx = remotes.WithMediaTypeKeyPrefix(ctx, "application/vnd.in-toto+json", "intoto") | ||
| ctx = remotes.WithMediaTypeKeyPrefix(ctx, "application/vnd.oci.empty.v1+json", "empty") |
Member
There was a problem hiding this comment.
Just to raise awareness, and in case it's relevant here and/or at some point; compose also defines a couple of media types for its artifacts, including an "empty" one; see https://github.com/docker/compose/blob/d9423f6872586c5cd9e1dd761bd5a8f02113a93c/internal/oci/push.go#L38-L60
thaJeztah
approved these changes
Oct 3, 2025
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
"LGTM" in case you need to be unblocked 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of: