driver/kubernetes: change DeploymentOpt.Replicas to int32 #3546
+8
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
force-pushed
the
int_convert
branch
2 times, most recently
from
657e3d0 to
0b4d9d8
Compare
Directly convert to a int32 instead of later conversion so that we can return an error if the value is out of range. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
int_convert
branch
from
0b4d9d8 to
88b4d5a
Compare
Member
Author
|
cc @crazy-max this will probably silence the remaining code alert |
AkihiroSuda
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directly convert to a int32 instead of later conversion so that we can return an error if the value is out of range.