commands: remove policy json-schema stub #3614
Merged
+5
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
previously approved these changes
Jan 16, 2026
Collaborator
jsternberg
left a comment
jsternberg
left a comment
There was a problem hiding this comment.
Fine as-is but I think we should just comment out the command code rather than remove it entirely since we reference it in a TODO.
commands/policy/root.go
Outdated
|
|
||
| cmd.AddCommand( | ||
| jsonSchemaCmd(), | ||
| // TODO: jsonSchemaCmd(), |
Collaborator
There was a problem hiding this comment.
Should we just keep the template for this function in the other file since we reference the function in a comment here? Might be easier to just comment out the code in json_schema.go instead.
Member
Author
There was a problem hiding this comment.
The linter will fail if there are unreferenced functions so a big block would need to be commented in. If you want I can modify the comment to just say "policy json-schema command" so it is not pointing to a function.
Remove stub for now so we don't ship it in a release. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
policy-json-stub
branch
from
865990d to
d0e4db2
Compare
jsternberg
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove stub for now so we don't ship it in a release.