fix: add skip-summary input to prevent GITHUB_STEP_SUMMARY exceeding 1MB limit#81
Merged
derekmisler merged 1 commit intodocker:mainfrom Mar 9, 2026
Merged
Conversation
…1MB limit When review-pr calls the root action, the full agent conversation log is dumped into $GITHUB_STEP_SUMMARY via `cat "$OUTPUT_FILE"`. For large PR reviews this exceeds GitHub's 1024KB limit, silently aborting the summary. Add a `skip-summary` input (default "false") that gates both the metadata table and the cleaned-output append. review-pr passes `skip-summary: "true"` since it writes its own purpose-specific summary downstream.
Contributor
Author
|
/describe |
Contributor
|
✅ PR description has been generated and updated! |
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review Summary
Assessment: 🟢 APPROVE
This PR correctly implements the skip-summary input feature to prevent GITHUB_STEP_SUMMARY from exceeding the 1MB limit when review-pr invokes the base action multiple times.
Key Changes Validated:
- ✅ Added
skip-summaryinput toaction.ymlwith appropriate default ("false") - ✅ Conditional logic correctly wraps both summary-writing blocks (lines 631-655 and step at line 718)
- ✅
review-pr/action.ymlcorrectly passesskip-summary: "true"to both agent invocations - ✅ String comparison syntax is appropriate for each context (Bash
[[uses double quotes, GitHub Actions expressions use single quotes)
No bugs found. The implementation is clean and follows GitHub Actions best practices. The feature will effectively prevent duplicate summary writes when invoked from review-pr.
krissetto
approved these changes
Mar 9, 2026
| skip-summary: | ||
| description: "Skip writing agent output to the job summary (useful when callers write their own summary)" | ||
| required: false | ||
| default: "false" |
There was a problem hiding this comment.
for backcompat or could it be useful?
Contributor
Author
There was a problem hiding this comment.
it's just because i don't want the root action outputting stuff if it was triggered by the review action. by itself, it's fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitHub enforces a 1MB limit on
GITHUB_STEP_SUMMARY. Thereview-prcomposite action invokes the base agent action multiple times (once for context gathering, once for the review pipeline), causing each invocation to append its full output to the step summary — which can easily exceed the limit on large PRs. This PR adds askip-summaryinput toaction.ymland sets it to"true"in bothreview-pragent calls, letting thereview-praction own its own summary instead.Changes
action.yml: Addedskip-summaryinput (default"false"). When"true", the job summary block is skipped entirely and theUpdate job summary with cleaned outputstep is also conditionally bypassed viaif: always() && inputs.skip-summary != 'true'.review-pr/action.yml: Passesskip-summary: "true"to both agent invocations (the initial context-gathering call at line ~474 and the main review pipeline call at line ~563), preventing duplicate/oversized summary writes from the sub-actions.How to Test
review-pron a large PR and confirmGITHUB_STEP_SUMMARYno longer hits the 1MB limit / workflow does not fail with a summary size error.action.ymldirectly (withoutskip-summary: "true"), the job summary is still written as before.review-praction still produces its own summary output correctly after suppressing the sub-action summaries.