Skip to content

Remove interleaved thinking if thinking is explicitly disabled #1404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krissetto merged 1 commit into from
Jan 17, 2026
Merged

Remove interleaved thinking if thinking is explicitly disabled #1404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/config/latest/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ type ModelConfig struct {
BaseURL string `json:"base_url,omitempty"`
ParallelToolCalls *bool `json:"parallel_tool_calls,omitempty"`
TokenKey string `json:"token_key,omitempty"`
// ProviderOpts allows provider-specific options. Currently used for "dmr" provider only.
// ProviderOpts allows provider-specific options.
ProviderOpts map[string]any `json:"provider_opts,omitempty"`
TrackUsage *bool `json:"track_usage,omitempty"`
// ThinkingBudget controls reasoning effort/budget:
Expand Down
3 changes: 0 additions & 3 deletions pkg/model/provider/clone.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ func CloneWithOptions(ctx context.Context, base Provider, opts ...options.Opt) P
opt(tempOpts)
mt := tempOpts.MaxTokens()
modelConfig.MaxTokens = &mt
if t := tempOpts.Thinking(); t != nil && !*t {
modelConfig.ThinkingBudget = nil
}
}

clone, err := New(ctx, &modelConfig, config.Env, mergedOpts...)
Expand Down
14 changes: 14 additions & 0 deletions pkg/model/provider/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,20 @@ func createDirectProvider(ctx context.Context, cfg *latest.ModelConfig, env envi

// Apply defaults from custom providers (from config) or built-in aliases
enhancedCfg := applyProviderDefaults(cfg, globalOptions.Providers())
if thinking := globalOptions.Thinking(); thinking != nil && !*thinking {
enhancedCfg.ThinkingBudget = nil

// with thinking explicitly disabled, also remove the interleaved_thinking provider option
if enhancedCfg.ProviderOpts != nil {
// Copy to avoid mutating shared ProviderOpts in the original config
optsCopy := make(map[string]any, len(enhancedCfg.ProviderOpts))
for key, value := range enhancedCfg.ProviderOpts {
optsCopy[key] = value
}
delete(optsCopy, "interleaved_thinking")
enhancedCfg.ProviderOpts = optsCopy
}
}

// Apply overrides (e.g., disable thinking if requested by session)
enhancedCfg = applyOverrides(enhancedCfg, &globalOptions)
Expand Down