Remove preceding white space from cobra help template#5730
Merged
thaJeztah merged 1 commit intodocker:masterfrom Feb 10, 2025
thelovekesh:update/help-template
Merged
Remove preceding white space from cobra help template#5730thaJeztah merged 1 commit intodocker:masterfrom thelovekesh:update/help-template
thaJeztah merged 1 commit intodocker:masterfrom
thelovekesh:update/help-template
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5730 +/- ##
=======================================
Coverage 59.26% 59.26%
=======================================
Files 353 353
Lines 29540 29540
=======================================
Hits 17508 17508
Misses 11052 11052
Partials 980 980 |
Signed-off-by: thelovekesh <lovekesh.kumar@rtcamp.com> Signed-off-by: Lovekesh Kumar <lovekesh.kumar@rtcamp.com>
thaJeztah
approved these changes
Feb 10, 2025
Member
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
I did a quick rebase and squash of the two commits; I'll merge if CI is happy 😄
Contributor
Author
|
Is the failing test related? |
Member
|
Nope; looks like a flaky test - I kicked CI to run again; |
Member
|
All green now 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While printing the usage text, I noticed there is always a empty line before the usage text. This was due to not using trim marker in cobra help text template. This PR fixes that.
- What I did
Remove preceding white space from cobra help template
- How I did it
Add a trim marker before printing the help template.
- How to verify it
Before:
Build the cli on this branch and re-run the binary. Now it will output:
Please note the there is no line before usage text.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)