golangci-lint: enable more linters, and some minor linting fixes#6086
Merged
thaJeztah merged 10 commits intodocker:masterfrom May 22, 2025
Merged
golangci-lint: enable more linters, and some minor linting fixes#6086thaJeztah merged 10 commits intodocker:masterfrom
thaJeztah merged 10 commits intodocker:masterfrom
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Format comments to be the same as in moby/moby for easier comparing. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6086 +/- ##
==========================================
- Coverage 55.02% 55.02% -0.01%
==========================================
Files 361 361
Lines 30131 30131
==========================================
- Hits 16581 16579 -2
- Misses 12595 12597 +2
Partials 955 955 🚀 New features to boost your workflow:
|
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
cli/command/container/formatter_stats_test.go:339:11: append to slice `stats` with non-zero initialized length (makezero)
stats = append(stats, entry)
^
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Enables the asasalint, exptostd, fatcontext, gocheckcompilerdirectives, iface, makezero, and spancheck linters. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
golangci_tweaks
branch
from
90900b0 to
d1e9946
Compare
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Benehiko
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)