Skip to content

vendor: update docker, api, client to master, consume client/pkg/stringid#6211

Merged
thaJeztah merged 2 commits intodocker:masterfrom
thaJeztah:bump_engine
Jul 28, 2025
Merged

vendor: update docker, api, client to master, consume client/pkg/stringid#6211
thaJeztah merged 2 commits intodocker:masterfrom
thaJeztah:bump_engine

Conversation

@thaJeztah
Copy link
Member

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2025

Codecov Report

❌ Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cli/command/plugin/install.go 66.66% 2 Missing ⚠️
cli/command/system/df.go 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@thaJeztah thaJeztah force-pushed the bump_engine branch 4 times, most recently from 5c0b9c0 to 9b8bf42 Compare July 26, 2025 14:45
@thaJeztah thaJeztah added this to the 29.0.0 milestone Jul 28, 2025
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah marked this pull request as ready for review July 28, 2025 07:03
@thaJeztah thaJeztah requested a review from Benehiko July 28, 2025 07:03
Copy link
Member

@Benehiko Benehiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one should also get a description on the PR body

@thaJeztah
Copy link
Member Author

I don't think there's much to add to the body; at least not for the second one. For the first one, I usually write a summary / add a diff for changes in upstream, but as we're iterating fast, it doesn't add a ton of value for these intermediate states.

@thaJeztah thaJeztah merged commit e2a4e42 into docker:master Jul 28, 2025
102 of 103 checks passed
@thaJeztah thaJeztah deleted the bump_engine branch July 28, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants