internal/registry: ParseRepositoryInfo: remove unused error return#6215
internal/registry: ParseRepositoryInfo: remove unused error return#6215thaJeztah merged 1 commit intodocker:masterfrom
Conversation
thaJeztah
added
status/2-code-review
kind/refactor
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
I think I had a bunch of follow-up changes stashed locally, but I didn't finish pushing those as a PR yet in the weekend; let's get this one in first. /cc @Benehiko |
Benehiko
left a comment
Benehiko
left a comment
There was a problem hiding this comment.
We just need a description I think on the PR body
Heh; not sure what to put in the body that's not already described in the first line. Something you had in mind? |
I updated the PR body, we can merge if you're happy with the description. |
Removed the error return from the `ParseRepositoryInfo` function. There are no validation steps inside `ParseRepositoryInfo` which could cause an error, so we always returned a nil error. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
ParseRepositoryInfo_no_err
branch
from
2ff70a5 to
86b5b52
Compare
thaJeztah
changed the title
3 participants
- What I did
Removed the error return from the
ParseRepositoryInfofunction. There are no validation steps insideParseRepositoryInfowhich could cause an error, so we always returned a nil error.- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)