Skip to content

vendor: docker/docker, moby/moby/api and moby/moby/client 4faedf2bec36#6226

Merged
thaJeztah merged 2 commits intodocker:masterfrom
thaJeztah:bump_engine
Jul 31, 2025
Merged

vendor: docker/docker, moby/moby/api and moby/moby/client 4faedf2bec36#6226
thaJeztah merged 2 commits intodocker:masterfrom
thaJeztah:bump_engine

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jul 31, 2025

notable changes:

  • api: remove deprecated NoBaseImageSpecifier
  • api/stdcopy: move to api/pkg/stdcopy
  • api/types/container: add aliases for go-connections/nat types
  • pkg/progress: move to api/pkg/progress
  • pkg/jsonmessage: move JSONError to api/types/jsonstream
  • pkg/jsonmessage: move JSONProgress to api/types/jsonstream
  • pkg/jsonmessage: move to client/pkg/jsonmessage
  • pkg/jsonmessage: remove github.com/morikuni/aec dependency
  • pkg/jsonmessage: stop printing deprecated progressDetail, errorDetail, remove DisplayJSONMessagesToStream and Stream interface
  • pkg/streamformatter: move to api/pkg/streamformatter
  • pkg/streamformatter: split from pkg/jsonmessage

full diff: moby/moby@2574c2b...4faedf2

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added this to the 29.0.0 milestone Jul 31, 2025
@thaJeztah thaJeztah force-pushed the bump_engine branch 2 times, most recently from b571166 to 5160f7f Compare July 31, 2025 11:29
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2025

Codecov Report

❌ Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
opts/swarmopts/port.go 88.88% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@thaJeztah thaJeztah force-pushed the bump_engine branch 2 times, most recently from ce07469 to e027f43 Compare July 31, 2025 11:35
@thaJeztah
Copy link
Member Author

Ugh. Something's borked; https://github.com/docker/cli/actions/runs/16647885085/job/47112862661?pr=6226

docker.io/library/alpine@sha256:69665d02cb32192e52e07644d76bc6f25abeb5410edc1c7a81a10ba3f0efb90a: Pulling from library/alpine
63b65145d645: Pulling fs layer
63b65145d645: Verifying Checksum
63b65145d645: Download complete
63b65145d645: Pull complete
Digest: sha256:69665d02cb32192e52e07644d76bc6f25abeb5410edc1c7a81a10ba3f0efb90a
Status: Downloaded newer image for alpine@sha256:69665d02cb32192e52e07644d76bc6f25abeb5410edc1c7a81a10ba3f0efb90a
docker.io/library/alpine@sha256:69665d02cb32192e52e07644d76bc6f25abeb5410edc1c7a81a10ba3f0efb90a
The push refers to repository [registry:5000/alpine]
unexpected EOF
make: *** [docker.Makefile:135: test-e2e-local] Error 1
Error: Process completed with exit code 2.

@thaJeztah thaJeztah marked this pull request as draft July 31, 2025 12:08
@thaJeztah thaJeztah force-pushed the bump_engine branch 2 times, most recently from a0deebd to ef1a472 Compare July 31, 2025 13:57
notable changes:

- api: remove deprecated NoBaseImageSpecifier
- api/stdcopy: move to api/pkg/stdcopy
- api/types/container: add aliases for go-connections/nat types
- pkg/progress: move to api/pkg/progress
- pkg/jsonmessage: move JSONError to api/types/jsonstream
- pkg/jsonmessage: move JSONProgress to api/types/jsonstream
- pkg/jsonmessage: move to client/pkg/jsonmessage
- pkg/jsonmessage: remove github.com/morikuni/aec dependency
- pkg/jsonmessage: stop printing deprecated progressDetail, errorDetail,
  remove DisplayJSONMessagesToStream and Stream interface
- pkg/streamformatter: move to api/pkg/streamformatter
- pkg/streamformatter: split from pkg/jsonmessage

full diff: moby/moby@2574c2b...4faedf2

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah changed the title vendor: docker/docker, moby/moby/api and moby/moby/client 39030fdf942e vendor: docker/docker, moby/moby/api and moby/moby/client 4faedf2bec36 Jul 31, 2025
@thaJeztah thaJeztah marked this pull request as ready for review July 31, 2025 15:55
@thaJeztah thaJeztah merged commit 66aca29 into docker:master Jul 31, 2025
87 checks passed
@thaJeztah thaJeztah deleted the bump_engine branch July 31, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants