Merged
Conversation
thaJeztah
added
status/2-code-review
kind/refactor
thaJeztah
force-pushed
the
less_pkg_errors
branch
from
b866575 to
7897964
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
thaJeztah
force-pushed
the
less_pkg_errors
branch
4 times, most recently
from
fa1880c to
9bd49b7
Compare
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
less_pkg_errors
branch
from
9bd49b7 to
27a7947
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR systematically replaces uses of github.com/pkg/errors with Go's standard library error handling, moving towards using errors and fmt.Errorf with error wrapping (%w verb) instead of the external package.
Key changes:
- Replace
errors.Wrapanderrors.Wrapfwithfmt.Errorfusing%wverb for error wrapping - Replace
errors.Errorfwithfmt.Errorforerrors.Newfor simple error creation - Update error message formatting to use standard library approaches
- Remove
pkg/errorsimport statements and adderrorsand/orfmtimports where needed
Reviewed Changes
Copilot reviewed 50 out of 50 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/volumespec/volumespec.go | Replace pkg/errors with standard library and fix slice initialization |
| e2e/cli-plugins/flags_test.go | Update error message capitalization for consistency |
| cli/trust/*.go | Convert error handling from pkg/errors to standard library |
| cli/required.go | Replace error creation and fix typo in error message |
| cli/registry/client/*.go | Convert error wrapping to use fmt.Errorf with %w |
| cli/manifest/types/types.go | Replace error wrapping with standard library |
| cli/manifest/store/store.go | Convert error formatting to use fmt.Errorf |
| cli/context/*.go | Replace error wrapping with standard library approach |
| cli/config/*.go | Convert error handling and improve defer error handling |
| cli/compose/*.go | Extensive conversion from pkg/errors to standard library |
| cli/command/*.go | Replace error handling and improve error handling patterns |
| cli/cobra.go | Convert error creation to use fmt.Errorf |
| return errors.Errorf( | ||
| "%[1]s: '%[2]s' requires at most %[3]d %[4]s\n\nUsage: %[5]s\n\nSRun '%[2]s --help' for more information", | ||
| return fmt.Errorf( | ||
| "%[1]s: '%[2]s' requires at most %[3]d %[4]s\n\nUsage: %[5]s\n\nRun '%[2]s --help' for more information", |
There was a problem hiding this comment.
Fixed typo by removing extra 'S' from 'SRun' to 'Run'
Benehiko
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still various locations remaining, but some need to be reviewed if we can / should change.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)