Unexport the builder and bake stub command#6284
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
c0f78d4 to
6dae3af
Compare
30b95f7 to
fdb82b3
Compare
This patch unexports the `builder` and `bake` stub command and it adds deprecation notices on the exported functions. It also registers the commands using the new `cli/internal/commands` package when the init function executes. Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
fdb82b3 to
1b9d076
Compare
|
For the changelog / release-notes, we should probably make it something more to the point, like; Go SDK: cli/command/builder: deprecate `NewBuilderCommand` and `NewBakeStubCommand`. These functions will be removed in the next release.Ultimately, for users of this code as a dependency, that's the part that matters, but we can touch-up those later as well. |
Okay, let me update the changelog description |
|
We'll probably need to rewrite some to a single large release-note, outlining that the release has many functions that were meant for internal use deprecated as part of our migration towards go modules (and people to contact us / open a ticket if there's anything deprecated that was essential to them). For most of the things we deprecated I checked if I could find external users, and for most that was not the case (or only used in archived projects), so I don't expect many to be impacted. |
oh! to be clear; that's not for this PR, but more a "general" note 😅 (in case my comment was ambiguous) |
This patch unexports the
builderandbakestub command and it addsdeprecation notices on the exported functions.
It also registers the commands using the new
cli/internal/commandspackage when the init function executes.
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)