-
Notifications
You must be signed in to change notification settings - Fork 5.7k
feat(up): Add --wait-services to up command #12172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This issue has been automatically marked as not stale anymore due to the recent activity. |
2 similar comments
|
This issue has been automatically marked as not stale anymore due to the recent activity. |
|
This issue has been automatically marked as not stale anymore due to the recent activity. |
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12172 +/- ##
==========================================
+ Coverage 51.68% 51.92% +0.24%
==========================================
Files 156 158 +2
Lines 15824 16482 +658
==========================================
+ Hits 8178 8559 +381
- Misses 6829 7049 +220
- Partials 817 874 +57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
IMHO #10596 should better be fixed by actual support for init containers, as the proposed UX is highly confusing between services to wait for and services selected as |
|
I agree with @ndeloof , with this UX it could be very easy to make mistakes and notice them $ docker compose up --wait-services serviceA,serviceB serviceC |
|
okay, thank you! I'll close the PR then |
What I did
Add
--wait-servicesflag into theupcommand so the user can specify what services they want to wait, it'll be useful in cases like this one #10596Example:
docker compose up --wait-services my-service1,my-service2Related issue
#10596
(not mandatory) A picture of a cute animal, if possible in relation to what you did