Skip to content

Conversation

@idsulik
Copy link
Collaborator

@idsulik idsulik commented Sep 29, 2024

What I did
Add --wait-services flag into the up command so the user can specify what services they want to wait, it'll be useful in cases like this one #10596

Example:
docker compose up --wait-services my-service1,my-service2

Related issue
#10596

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@stale
Copy link

stale bot commented Apr 8, 2025

This issue has been automatically marked as not stale anymore due to the recent activity.

2 similar comments
@stale
Copy link

stale bot commented Apr 8, 2025

This issue has been automatically marked as not stale anymore due to the recent activity.

@stale
Copy link

stale bot commented Apr 8, 2025

This issue has been automatically marked as not stale anymore due to the recent activity.

@stale stale bot removed stale labels Apr 8, 2025
idsulik added 3 commits April 8, 2025 07:50
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 53.12500% with 15 lines in your changes missing coverage. Please review.

Project coverage is 51.92%. Comparing base (8092ce9) to head (be774e9).
Report is 63 commits behind head on main.

Files with missing lines Patch % Lines
pkg/compose/start.go 48.14% 10 Missing and 4 partials ⚠️
cmd/compose/up.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12172      +/-   ##
==========================================
+ Coverage   51.68%   51.92%   +0.24%     
==========================================
  Files         156      158       +2     
  Lines       15824    16482     +658     
==========================================
+ Hits         8178     8559     +381     
- Misses       6829     7049     +220     
- Partials      817      874      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ndeloof
Copy link
Contributor

ndeloof commented Apr 8, 2025

IMHO #10596 should better be fixed by actual support for init containers, as the proposed UX is highly confusing between services to wait for and services selected as up target.

@glours
Copy link
Contributor

glours commented Apr 10, 2025

I agree with @ndeloof , with this UX it could be very easy to make mistakes and notice them

$ docker compose up --wait-services serviceA,serviceB serviceC

@idsulik
Copy link
Collaborator Author

idsulik commented Apr 10, 2025

okay, thank you! I'll close the PR then

@idsulik idsulik closed this Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants