-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Add --networks flag to config command #13021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: MohammadHasan Akbari <[email protected]>
|
I'm ok we introduce more config "subcommands" (as flags 🤪) but I'd like this to be aligned with docker cli |
I agree, and I'm ready for any follow-up PR:)) |
Signed-off-by: MohammadHasan Akbari <[email protected]>
|
I fixed the lint errors |
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [docker/compose](https://github.com/docker/compose) | patch | `v2.38.1` -> `v2.38.2` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>docker/compose (docker/compose)</summary> ### [`v2.38.2`](https://github.com/docker/compose/releases/tag/v2.38.2) [Compare Source](docker/compose@v2.38.1...v2.38.2) #### What's Changed ##### ✨ Improvements - Add `--networks` flag to config command by [@​jarqvi](https://github.com/jarqvi) in docker/compose#13021 ##### 🐛 Fixes - Add a Done event to model progress display by [@​glours](https://github.com/glours) in docker/compose#13008 - Fix the way we're checking if the provider metadata are empty or not by [@​glours](https://github.com/glours) in docker/compose#13017 - Build: fix service with profile missing secrets by [@​ndeloof](https://github.com/ndeloof) in docker/compose#13023 - Fix select dockerignore based on Dockerfile name set from symlink by [@​ndeloof](https://github.com/ndeloof) in docker/compose#13024 ##### 🔧 Internal - pkg/compose: remove redundant uses of strslice.StrSlice by [@​thaJeztah](https://github.com/thaJeztah) in docker/compose#13002 - (reactoring) avoid a global variable by introducing logConsumer decorator by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12945 - Chore: fix some minor issues in the comments by [@​mountdisk](https://github.com/mountdisk) in docker/compose#12991 - A single place for shell-out command setup by [@​ndeloof](https://github.com/ndeloof) in docker/compose#13007 - Add USER\_AGENT variable to cmd when shellouting by [@​glours](https://github.com/glours) in docker/compose#13025 ##### ⚙️ Dependencies - Bump golang to v1.23.10 by [@​glours](https://github.com/glours) in docker/compose#13004 - Bump go-viper/mapstructure to version v2.3.0 by [@​glours](https://github.com/glours) in docker/compose#13005 - Build(deps): bump github.com/moby/buildkit from 0.23.1 to 0.23.2 by [@​dependabot](https://github.com/dependabot) in docker/compose#13009 - Build(deps): bump github.com/docker/cli from 28.3.0+incompatible to 28.3.1+incompatible by [@​dependabot](https://github.com/dependabot) in docker/compose#13012 - Build(deps): bump github.com/docker/docker from 28.3.0+incompatible to 28.3.1+incompatible by [@​dependabot](https://github.com/dependabot) in docker/compose#13011 #### New Contributors - [@​mountdisk](https://github.com/mountdisk) made their first contribution in docker/compose#12991 **Full Changelog**: docker/compose@v2.38.1...v2.38.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC42Mi4xIiwidXBkYXRlZEluVmVyIjoiNDAuNjIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
What I did
Add a new flag to config command for print the network names, one per line.