Fix: allow tab auto-complete without executing#2321
Closed
joshbarrington wants to merge 1 commit intodocker:mainfrom
Closed
Fix: allow tab auto-complete without executing#2321joshbarrington wants to merge 1 commit intodocker:mainfrom
joshbarrington wants to merge 1 commit intodocker:mainfrom
Conversation
joshbarrington
force-pushed
the
fix/tab-auto-complete
branch
from
f1a1026 to
58e0328
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issues:
#2257
#1819
There was another implementation for a fix here: #2275
However I expanded upon that by simplifying and removing
AutoCompletefrom the command interface, as this was hardcoded to be always true. It is now driven by the Update function directly.I also added some more exhaustive tests and changes suggested through
mise lint.