Skip to content

Set a better displaylabel for secretservice #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Set a better displaylabel for secretservice #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions secretservice/secretservice_linux.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@ const SecretSchema *docker_get_schema(void)
return &docker_schema;
}

GError *add(char *label, char *server, char *username, char *secret) {
GError *add(char *label, char *server, char *username, char *secret, char *displaylabel) {
GError *err = NULL;

secret_password_store_sync (DOCKER_SCHEMA, SECRET_COLLECTION_DEFAULT,
server, secret, NULL, &err,
displaylabel, secret, NULL, &err,
"label", label,
"server", server,
"username", username,
Expand Down
4 changes: 3 additions & 1 deletion secretservice/secretservice_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,10 @@ func (h Secretservice) Add(creds *credentials.Credentials) error {
defer C.free(unsafe.Pointer(username))
secret := C.CString(creds.Secret)
defer C.free(unsafe.Pointer(secret))
displayLabel := C.CString("Docker credentials for " + creds.ServerURL)
defer C.free(unsafe.Pointer(displayLabel))

if err := C.add(credsLabel, server, username, secret); err != nil {
if err := C.add(credsLabel, server, username, secret, displayLabel); err != nil {
defer C.g_error_free(err)
errMsg := (*C.char)(unsafe.Pointer(err.message))
return errors.New(C.GoString(errMsg))
Expand Down
2 changes: 1 addition & 1 deletion secretservice/secretservice_linux.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const SecretSchema *docker_get_schema(void) G_GNUC_CONST;

#define DOCKER_SCHEMA docker_get_schema()

GError *add(char *label, char *server, char *username, char *secret);
GError *add(char *label, char *server, char *username, char *secret, char *displaylabel);
GError *delete(char *server);
GError *get(char *server, char **username, char **secret);
GError *list(char *label, char *** paths, char *** accts, unsigned int *list_l);
Expand Down