chore: use go build constraint

[crazy-max]

fixes #176

Switch to go build constraint. This allows to run tests against the right architecture. Errors in pass tests are now properly handled.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.74%. Comparing base (c740b99) to head (72391b3).
Report is 54 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #289      +/-   ##
==========================================
- Coverage   54.68%   52.74%   -1.94%     
==========================================
  Files           9        9              
  Lines         673      673              
==========================================
- Hits          368      355      -13     
- Misses        262      271       +9     
- Partials       43       47       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[crazy-max]

@thaJeztah I just noticed that this would solve #277 as well

[thaJeztah]

slightly on the fence on this one; I think the code in this repo works fine on any platform (if there's a pass binary to shell out to?)

[crazy-max]

agree, switched to unix.

[crazy-max]

actually !windows looks better.

[thaJeztah]

So for the pass helper; I guess the thing I was wondering here was that;

• the code in this repository (the helper itself) is basically platform-agnostic (including Windows)
• the "only" limitation we have for testing is that we don't have a pass binary on Windows
• so, wondering if we should actually exclude it on Windows?
• (but indeed, we can't currently run the tests, as those depend on a pass binary)
• ^^ do we know if there's an implementation of the pass binary for windows?

[thaJeztah]

It looks like there's at least one implementation (although last release is really old; https://github.com/mbos/Pass4Win)

[crazy-max]

Tried to install Pass4Win in ci but binary is not named pass.exe 😣 https://github.com/docker/docker-credential-helpers/actions/runs/5110526809/jobs/9186513917#step:9:8

So disable tests for windows in the meantime. Let me know if you prefer a specific tag like exclude_pass_tests that would be just set in CI.

[thaJeztah]

Look like it timed out or so 😔

[crazy-max]

@thaJeztah PTAL when you can 🙏, would like to rebase #288

[thaJeztah]

LGTM