Skip to content

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Oct 1, 2025

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@thaJeztah
Copy link
Member Author

Hmmm... some breaking change in Go?

=== RUN   TestWinCredHelper
    wincred_test.go:52: The stub received bad data.
--- FAIL: TestWinCredHelper (0.01s)
=== RUN   TestWinCredHelperRetrieveAliases
=== RUN   TestWinCredHelperRetrieveAliases/stored_with_port,_retrieved_without
    wincred_test.go:138: Error: failed to store secret for URL "https://foobar.docker.io:2376": The stub received bad data.
=== RUN   TestWinCredHelperRetrieveAliases/stored_as_https,_retrieved_without_scheme
    wincred_test.go:138: Error: failed to store secret for URL "https://foobar.docker.io": The stub received bad data.
=== RUN   TestWinCredHelperRetrieveAliases/stored_with_path,_retrieved_without
    wincred_test.go:138: Error: failed to store secret for URL "https://foobar.docker.io/one/two": The stub received bad data.
--- FAIL: TestWinCredHelperRetrieveAliases (0.00s)
    --- FAIL: TestWinCredHelperRetrieveAliases/stored_with_port,_retrieved_without (0.00s)
    --- FAIL: TestWinCredHelperRetrieveAliases/stored_as_https,_retrieved_without_scheme (0.00s)
    --- FAIL: TestWinCredHelperRetrieveAliases/stored_with_path,_retrieved_without (0.00s)
=== RUN   TestWinCredHelperRetrieveStrict
=== RUN   TestWinCredHelperRetrieveStrict/stored_as_https,_retrieved_using_http
    wincred_test.go:213: Error: failed to store secret for URL "https://foobar.docker.io:2376": The stub received bad data.
=== RUN   TestWinCredHelperRetrieveStrict/stored_as_http,_retrieved_using_https
    wincred_test.go:213: Error: failed to store secret for URL "http://foobar.docker.io:2376": The stub received bad data.
=== RUN   TestWinCredHelperRetrieveStrict/stored_as_http,_retrieved_without_scheme
    wincred_test.go:213: Error: failed to store secret for URL "http://foobar.docker.io": The stub received bad data.
=== RUN   TestWinCredHelperRetrieveStrict/non-matching_ports
    wincred_test.go:213: Error: failed to store secret for URL "https://foobar.docker.io:1234": The stub received bad data.
=== RUN   TestWinCredHelperRetrieveStrict/non-matching_paths
    wincred_test.go:213: Error: failed to store secret for URL "https://foobar.docker.io:1234/one/two": The stub received bad data.

@thaJeztah thaJeztah marked this pull request as draft October 1, 2025 13:26
@thaJeztah
Copy link
Member Author

Trying if downgrading to go1.24.7 helps

@thaJeztah
Copy link
Member Author

OK, works with go1.24 🤔 - let me revert that last commit and see if it was just a one-off failure

@thaJeztah
Copy link
Member Author

Hm... ok same problem again, so looks like go1.25 breaks windows 😞 ?

I can move the bump to go 1.25 to a separate PR; go1.24 is still supported, so we can use that for now

cc @akerouanton @crazy-max

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah changed the title update to go1.25.1, xx v1.7.0 update to go1.24.7, xx v1.7.0 Oct 1, 2025
@thaJeztah thaJeztah marked this pull request as ready for review October 1, 2025 14:24
@thaJeztah
Copy link
Member Author

Updated to use go1.24 for now, and moved the go1.25 bump to #387

@thaJeztah thaJeztah merged commit 2adf3cf into docker:master Oct 1, 2025
12 checks passed
@thaJeztah thaJeztah deleted the bump_go_deps branch October 1, 2025 14:29
@crazy-max
Copy link
Member

Hm... ok same problem again, so looks like go1.25 breaks windows 😞 ?

I can move the bump to go 1.25 to a separate PR; go1.24 is still supported, so we can use that for now

cc @akerouanton @crazy-max

Hum not sure will take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants