Add --start-daemon option to automatically start Docker service #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new --start-daemon command-line option that automatically starts and enables the Docker daemon service after installation. This addresses the cross-platform service management differences between distributions like CentOS and Ubuntu mentioned in issue docker#124. Features: - Detects systemd availability and uses appropriate service commands - Uses systemctl start/enable on systemd systems - Falls back to service/chkconfig on non-systemd systems - Supports --dry-run to show what commands would be executed - Only starts daemon when explicitly requested via --start-daemon flag - Works across all supported distributions (Ubuntu, Debian, CentOS, RHEL, Fedora) The implementation is safe by default - the daemon is only started when the user explicitly requests it, maintaining backward compatibility. Fixes docker#124 Signed-off-by: Gajesh Bhat <[email protected]>
gajeshbhat
force-pushed
the
feature/daemon-start-option
branch
from
b8ecd36 to
b99efe2
Compare
|
@thaJeztah Can you kindly take a look ? Do you think the feature would be useful? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new
--start-daemoncommand-line option that automatically starts and enables the Docker daemon service after installation, addressing issue #124.Problem
It would be useful to have an option to automatically start the Docker daemon after installation, noting that service management differs between distributions like CentOS and Ubuntu. Currently, users must manually run
sudo systemctl start dockerandsudo systemctl enable dockerafter installation.Solution
Added a
--start-daemonflag that:systemctl start docker && systemctl enable dockerservice docker start && chkconfig docker on(orupdate-rc.d)--dry-runto show what commands would be executedUsage
Testing
Thoroughly tested across all supported distributions: