Skip to content

Commit 66666f9

Browse files
committed
Properly convert non-string filters to expected string format
Signed-off-by: Joffrey F <[email protected]>
1 parent d9e08ae commit 66666f9

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

docker/utils/utils.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -386,7 +386,10 @@ def convert_filters(filters):
386386
v = 'true' if v else 'false'
387387
if not isinstance(v, list):
388388
v = [v, ]
389-
result[k] = v
389+
result[k] = [
390+
str(item) if not isinstance(item, six.string_types) else item
391+
for item in v
392+
]
390393
return json.dumps(result)
391394

392395

tests/unit/utils_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -457,8 +457,8 @@ def test_convert_filters(self):
457457
tests = [
458458
({'dangling': True}, '{"dangling": ["true"]}'),
459459
({'dangling': "true"}, '{"dangling": ["true"]}'),
460-
({'exited': 0}, '{"exited": [0]}'),
461-
({'exited': [0, 1]}, '{"exited": [0, 1]}'),
460+
({'exited': 0}, '{"exited": ["0"]}'),
461+
({'exited': [0, 1]}, '{"exited": ["0", "1"]}'),
462462
]
463463

464464
for filters, expected in tests:

0 commit comments

Comments
 (0)