Skip to content

Conversation

@Habbie
Copy link

@Habbie Habbie commented Feb 6, 2024

Proposed changes

Add --rm to the example docker run hello-world calls in the docs.

This would avoid leaving a (stopped) container lying around, as can be seen in docker ps -a.

I believe that, if you agree, multiple pages would want this change. Let me know and I'll push more commits (and I'm happy to squash afterwards).

Related issues (optional)

@Habbie Habbie requested a review from dvdksn as a code owner February 6, 2024 19:36
@netlify
Copy link

netlify bot commented Feb 6, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit ab334fe
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6702f309d0c75d00081aafad
😎 Deploy Preview https://deploy-preview-19321--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the area/install Relates to installing a product label Feb 6, 2024
@dvdksn
Copy link
Contributor

dvdksn commented Feb 6, 2024

I don't think this change is necessary. hello-world is very small, a few KB in size (excluding Windows).

@Habbie
Copy link
Author

Habbie commented Feb 6, 2024

I don't think this change is necessary. hello-world is very small, a few KB in size (excluding Windows).

It is 13.3kB on my system. run --rm does not recover those, and that was not the point of the PR. I trust a user will prune at some point and recover that space - which also does not seem important. I like my ps -a to cover things I wanted to have running.

@stephan-henningsen
Copy link

For what it's worth, I like the PR. The hello-world container is a simple test and only has temporary use; therefore it should leave no trace after it's done.

@docker-robot
Copy link

docker-robot bot commented May 6, 2024

Thanks for the pull request. We'd like to make our product docs better, but haven’t been able to review all the suggestions.
As our docs have also diverged, we do not have the bandwidth to review and rebase old pull requests.

If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a /remove-lifecycle stale comment.
If not, this pull request will be closed in 30 days. This helps our maintainers focus on the active pull requests.

Prevent pull requests from auto-closing with a /lifecycle frozen comment.

/lifecycle stale

@github-actions github-actions bot added the area/engine Issue affects Docker engine/daemon label May 6, 2024
@Habbie
Copy link
Author

Habbie commented May 6, 2024

/remove-lifecycle stale

Copy link

@offensive-vk offensive-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty cool trick!

@docker-robot
Copy link

docker-robot bot commented Sep 11, 2024

Thanks for the pull request. We'd like to make our product docs better, but haven’t been able to review all the suggestions.
As our docs have also diverged, we do not have the bandwidth to review and rebase old pull requests.

If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a /remove-lifecycle stale comment.
If not, this pull request will be closed in 30 days. This helps our maintainers focus on the active pull requests.

Prevent pull requests from auto-closing with a /lifecycle frozen comment.

/lifecycle stale

This would avoid leaving a (stopped) container lying around, as can be seen in `docker ps -a`.

I believe that, if you agree, multiple pages would want this change. Let me know and I'll push more commits (and I'm happy to squash afterwards).
@docker-robot docker-robot bot closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/engine Issue affects Docker engine/daemon area/install Relates to installing a product lifecycle/stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants