-
Notifications
You must be signed in to change notification settings - Fork 8k
add --rm to docker run line #19321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add --rm to docker run line #19321
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I don't think this change is necessary. |
It is 13.3kB on my system. |
|
For what it's worth, I like the PR. The |
|
Thanks for the pull request. We'd like to make our product docs better, but haven’t been able to review all the suggestions. If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a Prevent pull requests from auto-closing with a /lifecycle stale |
|
/remove-lifecycle stale |
offensive-vk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty cool trick!
|
Thanks for the pull request. We'd like to make our product docs better, but haven’t been able to review all the suggestions. If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a Prevent pull requests from auto-closing with a /lifecycle stale |
This would avoid leaving a (stopped) container lying around, as can be seen in `docker ps -a`. I believe that, if you agree, multiple pages would want this change. Let me know and I'll push more commits (and I'm happy to squash afterwards).
Proposed changes
Add
--rmto the exampledocker run hello-worldcalls in the docs.This would avoid leaving a (stopped) container lying around, as can be seen in
docker ps -a.I believe that, if you agree, multiple pages would want this change. Let me know and I'll push more commits (and I'm happy to squash afterwards).
Related issues (optional)