-
Notifications
You must be signed in to change notification settings - Fork 8.1k
admin: add org access tokens #20731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
admin: add org access tokens #20731
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
21885b5 to
2455186
Compare
1a20807 to
3732078
Compare
francesco-corti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great.
Thank you.
|
What's your process these days @craig-osterhout? We just wait to merge this until we release? Just want to make sure once we all check that it isn't merged. |
Yep, it'll get merged during release. For feature releases, I'll verify in Slack before merging. I'll throw a do not merge label on it just in case. |
Signed-off-by: Craig Osterhout <[email protected]>
Signed-off-by: Craig Osterhout <[email protected]>
Signed-off-by: Craig Osterhout <[email protected]>
a110c2c to
c2d2564
Compare
|
question: Can we slap a "beta" tag on this? It won't be early access, but beta when released. |
Signed-off-by: Craig <[email protected]>
|
Hey team! I found this PR as I'm starting to use OATs internally and wanted to learn more (yes I clicked the "learn more" link in the Docker Admin Console and got a 404 😅). I tested a new generated OAT manually and did a The "go" link https://docs.docker.com/go/access-tokens/ links to https://docs.docker.com/security/for-developers/access-tokens/ |
That's good feedback. We'll likely have updates here for messaging on the CLI. I'll reach out to the runtime team tomorrow about this messaging and how we can update those links. |
Signed-off-by: Craig <[email protected]>
sarahsanders-docker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@technicallyjosh @pla-sam Approving the changes w/ help from Craig if you want to review as well, these are ready to go out today
|
I'll merge when we pull the trigger @sarahsanders-docker @craig-osterhout |
Description
https://deploy-preview-20731--docsdocker.netlify.app/security/for-admins/access-tokens/
https://deploy-preview-20731--docsdocker.netlify.app/admin/organization/activity-logs/#event-definitions
https://deploy-preview-20731--docsdocker.netlify.app/docker-hub/service-accounts/
Related issues or tickets
ENGDOCS-2167
Reviews