Skip to content

Conversation

@craig-osterhout
Copy link
Contributor

@craig-osterhout craig-osterhout commented Aug 28, 2024

Description

Related issues or tickets

ENGDOCS-2167

Reviews

  • Technical review
  • Editorial review
  • Product review

@netlify
Copy link

netlify bot commented Aug 28, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 660044a
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/670e91998ec0f300081c4631
😎 Deploy Preview https://deploy-preview-20731--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added area/hub Issue affects Docker Hub area/security area/admin Relates to Docker Admin labels Aug 28, 2024
@craig-osterhout craig-osterhout marked this pull request as draft August 28, 2024 23:34
@craig-osterhout craig-osterhout force-pushed the engdocs-2167 branch 2 times, most recently from 1a20807 to 3732078 Compare August 29, 2024 20:36
@craig-osterhout craig-osterhout requested review from francesco-corti, pla-sam and technicallyjosh and removed request for aevesdocker August 29, 2024 20:37
@craig-osterhout craig-osterhout marked this pull request as ready for review August 29, 2024 20:48
Copy link

@francesco-corti francesco-corti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great.
Thank you.

@technicallyjosh
Copy link
Contributor

What's your process these days @craig-osterhout? We just wait to merge this until we release? Just want to make sure once we all check that it isn't merged.

@craig-osterhout
Copy link
Contributor Author

What's your process these days @craig-osterhout? We just wait to merge this until we release? Just want to make sure once we all check that it isn't merged.

Yep, it'll get merged during release. For feature releases, I'll verify in Slack before merging. I'll throw a do not merge label on it just in case.

@craig-osterhout craig-osterhout added the status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged. label Sep 4, 2024
Signed-off-by: Craig Osterhout <[email protected]>
Signed-off-by: Craig Osterhout <[email protected]>
Signed-off-by: Craig Osterhout <[email protected]>
@technicallyjosh
Copy link
Contributor

question: Can we slap a "beta" tag on this? It won't be early access, but beta when released.

Signed-off-by: Craig <[email protected]>
technicallyjosh
technicallyjosh previously approved these changes Oct 2, 2024
@StefanScherer
Copy link
Member

Hey team! I found this PR as I'm starting to use OATs internally and wanted to learn more (yes I clicked the "learn more" link in the Docker Admin Console and got a 404 😅).

I tested a new generated OAT manually and did a docker login and saw this message in my terminal, and I wonder if there should be some adjustments once we merge this PR? 🤔

$ docker login
Log in with your Docker ID or email address to push and pull images from Docker Hub. If you don't have a Docker ID, head over to https://hub.docker.com/ to create one.
You can log in with your password or a Personal Access Token (PAT). Using a limited-scope PAT grants better security and is required for organizations using SSO. Learn more at https://docs.docker.com/go/access-tokens/

The "go" link https://docs.docker.com/go/access-tokens/ links to https://docs.docker.com/security/for-developers/access-tokens/
Maybe we need to update the link once this PR got merged?

@technicallyjosh
Copy link
Contributor

The "go" link docs.docker.com/go/access-tokens links to docs.docker.com/security/for-developers/access-tokens
Maybe we need to update the link once this PR got merged?

That's good feedback. We'll likely have updates here for messaging on the CLI. I'll reach out to the runtime team tomorrow about this messaging and how we can update those links.

Copy link
Contributor

@sarahsanders-docker sarahsanders-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@technicallyjosh @pla-sam Approving the changes w/ help from Craig if you want to review as well, these are ready to go out today

@technicallyjosh
Copy link
Contributor

I'll merge when we pull the trigger @sarahsanders-docker @craig-osterhout

@technicallyjosh technicallyjosh merged commit 23b9df6 into docker:main Oct 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/admin Relates to Docker Admin area/hub Issue affects Docker Hub area/security area/tests status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants