Skip to content

Conversation

@dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Oct 11, 2024

@dvdksn dvdksn requested a review from a team October 11, 2024 09:33
@dvdksn dvdksn self-assigned this Oct 11, 2024
@github-actions github-actions bot added the area/api Relates to Docker API docs label Oct 11, 2024
@netlify
Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 7b5b54c
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/670d1020df38de00086ea1f2
😎 Deploy Preview https://deploy-preview-21103--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the area/release Relates to CI or deployment label Oct 11, 2024
Copy link
Contributor

@austinvazquez austinvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified link is fixed.

@thaJeztah
Copy link
Member

@dvdksn Maybe it's how the preview works, but it looks like this is redirecting /reference/api/engine/v1.47/, but doesn't redirect /engine/api/v1.47/

@dvdksn
Copy link
Contributor Author

dvdksn commented Oct 14, 2024

@thaJeztah ah yeah you're right! My bad!

@dvdksn dvdksn force-pushed the fix-api-v1.47-404 branch from bae0e32 to 5b7c057 Compare October 14, 2024 08:10
@thaJeztah
Copy link
Member

Something's still broken, but I don't see immediately what's the cause;

Is it for some reason the combination of the content/reference/api/engine/** with the /reference/api/engine/latest/ alias?

@dvdksn
Copy link
Contributor Author

dvdksn commented Oct 14, 2024

🤦🏻 I had aliased /api/engine/v1.47/ but it should be /engine/api/v1.47/, I'd swapped places of api and engine

@dvdksn dvdksn force-pushed the fix-api-v1.47-404 branch from 5b7c057 to 7b5b54c Compare October 14, 2024 12:35
@thaJeztah
Copy link
Member

LOL! And there I looked at it multiple times, and didn't see it either 😂

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thaJeztah thaJeztah merged commit ad800a5 into docker:main Oct 14, 2024
13 checks passed
@dvdksn dvdksn deleted the fix-api-v1.47-404 branch October 14, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/api Relates to Docker API docs area/release Relates to CI or deployment status/review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[400]: /engine/api/v1.47/ [404]: /engine/api/v1.47/

3 participants