Skip to content

Conversation

@sarahsanders-docker
Copy link
Contributor

@sarahsanders-docker sarahsanders-docker commented Nov 20, 2024

Description

Related issues or tickets

Reviews

Final sign offs in Notion doc

@netlify
Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit a03f7c1
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/675763ba7859e00008af8c13
😎 Deploy Preview https://deploy-preview-21476--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added area/hub Issue affects Docker Hub area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/security area/subscription Relates to Docker pricing and subscription area/admin Relates to Docker Admin area/scout Relates to Docker Scout area/billing area/accounts Relates to Docker accounts area/build-cloud area/guides labels Nov 20, 2024
@sarahsanders-docker sarahsanders-docker changed the title add docker consolidated subscriptions add docker consolidated subscriptions (WIP) Nov 24, 2024
@sarahsanders-docker sarahsanders-docker added the status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged. label Nov 24, 2024
@sarahsanders-docker sarahsanders-docker force-pushed the consolidated-plans-updates branch 3 times, most recently from c0593fb to af31b2b Compare November 26, 2024 20:09
@sarahsanders-docker sarahsanders-docker force-pushed the consolidated-plans-updates branch from 338bef4 to aabc026 Compare December 3, 2024 23:49
@sarahsanders-docker sarahsanders-docker marked this pull request as ready for review December 3, 2024 23:50
@sarahsanders-docker sarahsanders-docker requested a review from a team December 3, 2024 23:50
@sarahsanders-docker sarahsanders-docker force-pushed the consolidated-plans-updates branch 3 times, most recently from acf7ef7 to 47ac5a4 Compare December 5, 2024 16:28
shawnaxsom
shawnaxsom previously approved these changes Dec 9, 2024
dvdksn
dvdksn previously approved these changes Dec 9, 2024
Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sarahsanders-docker sarahsanders-docker dismissed stale reviews from dvdksn and shawnaxsom via c30b8d1 December 9, 2024 17:24
dvdksn
dvdksn previously approved these changes Dec 9, 2024
@sarahsanders-docker sarahsanders-docker mentioned this pull request Dec 9, 2024
1 task
Copy link

@macInfinity macInfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

sarahsanders-docker added a commit that referenced this pull request Dec 9, 2024
## Description
- There is a 404 link in an email being sent to over 400 customers today
that points to a page in tomorrow (12/10s) [subscription updates
PR](#21476)
- To fix this, we are adding scale.md today, removing any dead links.
Tomorrow's PR will overwrite this and add the correct content

## Related issues or tickets
- https://docker.slack.com/archives/C0334FHU341/p1733512718061719

## Reviews
@ob1dev
- [ ] Editorial review

---------

Co-authored-by: Oleg Burov <[email protected]>
@sarahsanders-docker sarahsanders-docker removed the status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged. label Dec 10, 2024
@usha-mandya usha-mandya changed the title add docker consolidated subscriptions (WIP) add docker consolidated subscriptions Dec 10, 2024
Copy link
Member

@usha-mandya usha-mandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: :)

@sarahsanders-docker sarahsanders-docker merged commit 316115f into docker:main Dec 10, 2024
13 of 14 checks passed
@sarahsanders-docker sarahsanders-docker deleted the consolidated-plans-updates branch December 18, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/accounts Relates to Docker accounts area/admin Relates to Docker Admin area/billing area/build-cloud area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/guides area/hub Issue affects Docker Hub area/scout Relates to Docker Scout area/security area/subscription Relates to Docker pricing and subscription area/tests status/review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants