Add multi-stage builds to the C++ guide #21562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
aerabi
commented
Dec 4, 2024
dvdksn
reviewed
Dec 4, 2024
aerabi
force-pushed
the
aerabi/add-multistage
branch
from
63107cf to
ff86f7f
Compare
craig-osterhout
requested changes
Feb 26, 2025
Contributor
craig-osterhout
left a comment
craig-osterhout
left a comment
There was a problem hiding this comment.
Thank you. It looks good. There are couple minor fixes.
Also, can you help update the clone repository command in develop.md from git clone https://github.com/Pradumnasaraf/c-plus-plus-docker.git to git clone https://github.com/dockersamples/c-plus-plus-docker.git
Contributor
Author
|
Thanks for the reviews, @craig-osterhout! I pushed another commit, PTAL. 🙏 |
craig-osterhout
approved these changes
Feb 27, 2025
Contributor
craig-osterhout
left a comment
craig-osterhout
left a comment
There was a problem hiding this comment.
Thank you. LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Having a multi-stage build is an essential thing to learn for containerizing a compiled language.
Related issues or tickets
N/A
Reviews