Skip to content

Conversation

@mattprintz
Copy link

Description

This fixes an issue in the profiles how-to where the text uses the incorrect profile in one spot.
The phpmyadmin service in the example is associated with the "debug" profile, but the text implies that it is associated with the "dev" profile.

Reviews

  • Technical review
  • Editorial review
  • Product review

Fix slight error in docs, referencing incorrect profile.
@github-actions github-actions bot added the area/compose Relates to docker-compose.yml spec or docker-compose binary label Jan 13, 2025
@netlify
Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 87d4fb5
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6785796947c1c600080f92fc
😎 Deploy Preview https://deploy-preview-21805--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aevesdocker
Copy link
Contributor

Hi @mattprintz, thanks for the PR. The docs are actually correct as is. This is because phpmyadmin is dependent on the db service, which requires the profiles dev. This is explained in the sentences below the example.

@mattprintz
Copy link
Author

@aevesdocker Thanks. I now understand what the documentation was intending. I've updated my branch in an attempt to make the wording more clear, in case such a change was desirable.

The updated commit can be previewed here:
https://github.com/mattprintz/docs/commit/d0fadeede65648db51bdc4ce3a68bd60ae576609

Let me know if this is a good change and I should go ahead and create a new PR, or if you prefer the existing wording.

@aevesdocker
Copy link
Contributor

Thanks @mattprintz but I think we'll leave the wording for now. If we get further reports on this issue, we'll revisit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/compose Relates to docker-compose.yml spec or docker-compose binary

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants