-
Notifications
You must be signed in to change notification settings - Fork 8k
build: use arm-native gha runners for distributed multi-platform #21854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
106b598 to
b0ef15d
Compare
b0ef15d to
949d060
Compare
crazy-max
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thanks @dvdksn!
Let's keep this one aside until these runners are GA.
|
Looks good 👍 A very similar version of this running can be seen here: EnAccess/micropowermanager#476 But I agree it makes sense to postpone until the ARM runners are GA. |
|
Thanks for the pull request. We'd like to make our product docs better, but haven’t been able to review all the suggestions. If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a Prevent pull requests from auto-closing with a /lifecycle stale |
949d060 to
5f37211
Compare
| - linux/arm64 | ||
| include: | ||
| - platform: linux/amd64 | ||
| os: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe runner instead to be more explicit like https://github.com/docker/github-builder-experimental/pull/22/files#diff-b03722d9ee6e9591756da90c4c9116cd562a72bca526d047fa274238d9fa082aR6-R10
| os: ubuntu-latest | |
| runner: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
Signed-off-by: David Karlsson <[email protected]>
5f37211 to
147a31d
Compare
These runners are currently in public preview: https://github.com/orgs/community/discussions/148648