Skip to content

Conversation

@aevesdocker
Copy link
Contributor

@aevesdocker aevesdocker commented Jan 29, 2025

Description

Add new DD CLI command for 4.38

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions bot added area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/cli Relates to the CLI client labels Jan 29, 2025
@netlify
Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit b82dfea
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/679ba185f0f38300086965f8
😎 Deploy Preview https://deploy-preview-21917--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aevesdocker aevesdocker added this to the 4.38 milestone Jan 29, 2025
@aevesdocker aevesdocker requested a review from Xeeynamo January 29, 2025 11:06
Copy link
Contributor

@Xeeynamo Xeeynamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@aevesdocker aevesdocker marked this pull request as ready for review January 29, 2025 15:06
@aevesdocker aevesdocker requested a review from dvdksn as a code owner January 29, 2025 15:06
@aevesdocker aevesdocker requested a review from a team January 29, 2025 15:07
availability: Beta
requires: Docker Desktop 4.37 and later
Docker Desktop CLI update:
requires: Docker Desktop 4.38 and later
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you want to add release notes here (not sure if you want to or not!) you can use markdown around the version number. Docker Desktop [4.38](release-notes-url) and later

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes! Will add in a follow-up once those release notes are out

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if "Docker Desktop CLI update" will be easy to remember what it means in the future? Is there a better/more semantic feature id that we could use? (This is probably a good idea generally - I have not reviewed the feature IDs in this file so far, but if they are too generic, it'll be difficult to keep track of them down the line. How do we manage this inventory of feaures?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a standardised pattern is a good idea. Something like {product}-{feature-category}-{specific-feature} perhaps

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah something like that

@Xeeynamo Xeeynamo mentioned this pull request Jan 30, 2025
3 tasks
@aevesdocker aevesdocker merged commit 414c77d into docker:main Jan 30, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cli Relates to the CLI client area/desktop Issue affects a desktop edition of Docker. E.g docker for mac status/review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants