-
Notifications
You must be signed in to change notification settings - Fork 8.1k
ENGDOCS-2405a #21917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENGDOCS-2405a #21917
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Xeeynamo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
| availability: Beta | ||
| requires: Docker Desktop 4.37 and later | ||
| Docker Desktop CLI update: | ||
| requires: Docker Desktop 4.38 and later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you want to add release notes here (not sure if you want to or not!) you can use markdown around the version number. Docker Desktop [4.38](release-notes-url) and later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes! Will add in a follow-up once those release notes are out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if "Docker Desktop CLI update" will be easy to remember what it means in the future? Is there a better/more semantic feature id that we could use? (This is probably a good idea generally - I have not reviewed the feature IDs in this file so far, but if they are too generic, it'll be difficult to keep track of them down the line. How do we manage this inventory of feaures?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having a standardised pattern is a good idea. Something like {product}-{feature-category}-{specific-feature} perhaps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah something like that
Description
Add new DD CLI command for 4.38
Related issues or tickets
Reviews