-
Notifications
You must be signed in to change notification settings - Fork 8.1k
fix: netlify builds #22757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sarahsanders-docker
merged 17 commits into
docker:main
from
sarahsanders-docker:fix-netlify-builds
Jun 3, 2025
Merged
fix: netlify builds #22757
Changes from 3 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
e0f7593
fix: netlify builds
sarahsanders-docker 74d6984
adjust
sarahsanders-docker 1c7d73e
disable secret smart scan
sarahsanders-docker cfca946
fix code block
sarahsanders-docker c77bde9
zero width dash
sarahsanders-docker 4c1fce8
try html hyphen
sarahsanders-docker 20c9361
original fix
sarahsanders-docker a07f8c0
zero-width
sarahsanders-docker 41febe6
add closing ticks
sarahsanders-docker bb71c8c
comment the fence
sarahsanders-docker a5f8cfe
try Hugo highlight
sarahsanders-docker 7c254d4
try toml
sarahsanders-docker 2d86f34
typo
sarahsanders-docker c209834
try toml on both code blocks
sarahsanders-docker 6114fe4
remove minify
sarahsanders-docker e1d1ddc
add back minify, disable smart scan
sarahsanders-docker e7161f3
exclude file
sarahsanders-docker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,7 @@ NODE_ENV = "production" | |
| HUGO_VERSION = "0.141.0" | ||
| HUGO_ENABLEGITINFO = "true" | ||
| HUGO_ENVIRONMENT = "preview" | ||
| SECRETS_SCAN_SMART_DETECTION_ENABLED = "false" | ||
|
|
||
| [context.deploy-preview] | ||
| command = "hugo --gc --minify -b $DEPLOY_PRIME_URL && npx [email protected]" | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm; do we know what it tripped over? Did it detect a possible secret anywhere as false positive (if so, could we update those docs?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pinpointed where it tripped over, trying something with my next commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thaJeztah tripping on this code block https://docs.docker.com/contribute/file-conventions/#:~:text=Here%27s%20an%20example%20of%20a%20valid%20(but%20contrived)%20page%20metadata.%20The%20order%20of%20the%20metadata%20elements%20in%20the%20front%20matter%20isn%27t%20important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting; could it be related to that code being changed to "text" highlighting? I just saw this PR;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could try if it likes
yamlortomlfor those (I think it's effective either of those)Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this started happening before that PR went out, I encountered it first thing this morning (9am EST)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it's weird; also don't see any keywords in there that I could see as "this may be interpreted as security". At most the formatting (starting with
--interpreted as "start of private key" or something silly like that)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yaml and toml aren't working 😭