-
Notifications
You must be signed in to change notification settings - Fork 8.1k
docs: Added section for WSL installation and verification #22825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
27b2476
Added instructions for WSL installation
chaomonica 1286b7c
Updated after linter feedback
chaomonica 1e02e03
Updated after linter feedback
chaomonica a9d0db1
Added note on installer flag
chaomonica 7032351
Fix linter feedback
chaomonica 7395a76
Add s
chaomonica 1e590f0
Add new section after feedback
chaomonica 4ae3ec0
Change order of sections to prevent confusion
chaomonica e29e731
Respond to linter feedback
chaomonica 4a706b9
Respond to linter feedback
chaomonica bf6a27d
Fix installer flag quotes
chaomonica 4e416a3
Fix link
chaomonica File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite sure about this one.
When in WSL mode, you only activate the Windows Service if you select "Add the *.docker.internal names to the host's /etc/hosts file (Requires password)" from settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Craig, I'll double check this on a VM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that UAC prompt appears in the scenario you mentioned and oops, I missed the part on "com.docker.service is required by Windows containers and Hyper-V backend".
I'll run through installation again tomorrow and fix this. Thanks again @chelnak!
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chaomonica / @chelnak we can word it something like this:
Title can be "Administrator Privileges and Installation Requirements", since this is generic, it can be outside the "WSL: Verification and Setup" section.
Installing Docker Desktop requires administrator privileges. However, once installed, it can be used without administrative access. Some actions, though, still need elevated permissions. For details, see [Understand permission requirements for Windows].
If your users do not have administrator rights and plan to perform operations that require elevated privileges, be sure to install Docker Desktop using the --always-run-service installer flag. This ensures those actions can still be executed without prompting for UAC elevation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chelnak I've updated the "Administrator Privileges and Installation Requirements" with @karman-docker 's section above and additionally moved this section ahead of the WSL sections to avoid confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you.