davidbn Docs base #22944
Closed
davidbn Docs base #22944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configure nginx to redirect to 404.html
Change keyserver for nginx
Use shallow clone and shallow checkout
We are compliant with it; we need to fork the source repo that generates this so we can iterate when we please, however.
1. It does not make sense to run apk many times. 2. Use --no-cache flag to avoid doing update, as per https://github.com/gliderlabs/docker-alpine/blob/master/docs/usage.md#disabling-cache Signed-off-by: Kir Kolyshkin <[email protected]>
This is needed for the following reasons: 1. gh-pages >= 174 is required to fix the issue docker#4178 [1] 2. Not using a tag leads to pulling some unknown version of the image, which might or might not work. 3. Not using a tag means the image is never rebuilt. NOTE: it was not possible to use a tag before, as recent gh-pages releases were not tagged on dockerhub; this is now fixed (see Starefossen/docker-github-pages#36). [1] docker#4178 Signed-off-by: Kir Kolyshkin <[email protected]>
❌ Deploy Preview for docsdocker failed. Why did it fail? →
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues or tickets
Reviews