Add deb822 apt sources to install section in Debian manual #23249
+8
−4
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -114,11 +114,21 @@ Docker from the repository. | |||||
| sudo curl -fsSL {{% param "download-url-base" %}}/gpg -o /etc/apt/keyrings/docker.asc | ||||||
| sudo chmod a+r /etc/apt/keyrings/docker.asc | ||||||
|
|
||||||
| # Add the repository to Apt sources (legacy format): | ||||||
| echo \ | ||||||
| "deb [arch=$(dpkg --print-architecture) signed-by=/etc/apt/keyrings/docker.asc] {{% param "download-url-base" %}} \ | ||||||
| $(. /etc/os-release && echo "$VERSION_CODENAME") stable" | \ | ||||||
| sudo tee /etc/apt/sources.list.d/docker.list > /dev/null | ||||||
|
|
||||||
| # Add the repository to Apt sources (new deb822 format, introduced with Trixie): | ||||||
| echo -e \ | ||||||
| "Types: deb\n\ | ||||||
| URIs: https://download.docker.com/linux/debian/\n\ | ||||||
| Suites: $(. /etc/os-release && echo "$VERSION_CODENAME")\n\ | ||||||
| Components: stable\n\ | ||||||
| Signed-By: /etc/apt/keyrings/docker.gpg" | \ | ||||||
|
||||||
| Signed-By: /etc/apt/keyrings/docker.gpg" | \ | |
| Signed-By: /etc/apt/keyrings/docker.asc" | \ |
Just a typo correction
There was a problem hiding this comment.
Wrong way around. This should be a machine-readable file not ASCII export.
There was a problem hiding this comment.
All right, then .gpg should be fine. Kept that in the newest commit 7e2650e
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks for clarifying! Now I switched back to the originally used .asc.
But if you prefer gpg --dearmor I can also include that. Just let me know. 👍
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deb822 format was introduced in apt version 1.1 ten years before the release of Trixie
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh 😅 , thanks for that comment.
Did not know that, I can adjust the comment together with possible other review comments.
Maybe we should just say:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drop this comment and the use of non-deb822 format sources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed with 7e2650e
(Hope it is still ok to keep the original comment, which just stated
# Add the repository to Apt sources:. The paragraph seemed to me a bit lonely without the comment. At least explanations about (non-)deb822 are gone now).