-
Notifications
You must be signed in to change notification settings - Fork 8.1k
engine/security/rootless: split to multiple pages ; remove outdated/duplicated info #23302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @thaJeztah |
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This commit only splits the page. The content will be updated in subsequent commits. Signed-off-by: Akihiro Suda <[email protected]>
4116d2d to
75284be
Compare
Setup: - `dockerd-rootless-setuptool.sh` has been improved to show help when the prerequisites are not satisfied. Users no longer need to read the **lengthy** "prerequisites" documentation unless they encounter issues. - The document had duplicated descriptions about dbus, uidmap, and machinectl stuffs in several places. Graph drivers: - Rootless OverlayFS has been merged into the upstream since kernel 5.11: torvalds/linux@459c7c5 . Ubuntu no longer patches the kernel. - FUSE-OverlayFS is typically no longer needed on the current supported distros, except EL 8. SELinux: - Remove a workaround for an issue that was already fixed in Docker Engine v20.10.8. CLI: - `docker context use rootless` no longer needs to be executed manually, since Docker v23. (moby/moby PR 43061) Signed-off-by: Akihiro Suda <[email protected]>
```
Warning: [vale] reported by reviewdog 🐶
[Docker.Avoid] Consider removing 'very'.
Raw Output:
{"message": "[Docker.Avoid] Consider removing 'very'.", "location": {"path": "content/manuals/engine/security/rootless/_index.md", "range": {"start": {"line": 18, "column": 9}}}, "severity": "WARNING"}
reviewdog: found at least one issue with severity greater than or equal to the given level: warning
Error: [vale] reported by reviewdog 🐶
[Vale.Terms] Use 'cgroup' instead of 'Cgroup'.
Raw Output:
{"message": "[Vale.Terms] Use 'cgroup' instead of 'Cgroup'.", "location": {"path": "content/manuals/engine/security/rootless/troubleshoot.md", "range": {"start": {"line": 73, "column": 3}}}, "severity": "ERROR"}
```
Signed-off-by: Akihiro Suda <[email protected]>
|
@thaJeztah Could you take a look? 🙏 |
vvoland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM! Spotted one typo though
|
@aevesdocker PTAL |
Co-authored-by: Paweł Gronowski <[email protected]>
aevesdocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvements, thank you @AkihiroSuda
https://docs.docker.com/engine/security/rootless/ was too lengthy and giving a false sense that Rootless mode was quite clunky and hard to use, although actually it can be just set up in a single command:
Description
Commit 1:
engine/security/rootless: split to multiple pagesThis commit only splits the page.
The content will be updated in subsequent commits.
Commit 2:
engine/security/rootless: remove outdated/duplicated infoSetup:
dockerd-rootless-setuptool.shhas been improved to show help when the prerequisites are not satisfied.Users no longer need to read the lengthy "prerequisites" documentation unless they encounter issues.
The document had duplicated descriptions about dbus, uidmap, and machinectl stuffs in several places.
Graph drivers:
Rootless OverlayFS has been merged into the upstream since kernel 5.11:
torvalds/linux@459c7c5 .
Ubuntu no longer patches the kernel.
FUSE-OverlayFS is typically no longer needed on the current supported distros,
except EL 8.
SELinux:
CLI:
docker context use rootlessno longer needs to be executed manually,since Docker v23. (docker-rootless-setuptools.sh: use context after install moby/moby#43061)
Related issues or tickets
Reviews
Preview
https://deploy-preview-23302--docsdocker.netlify.app/engine/security/rootless/