Networking docs fixes for moby 29 #23409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/engine
robmry
force-pushed
the
moby29_bug_fixes
branch
from
8766ac0 to
bfb53e1
Compare
robmry
force-pushed
the
moby29_bug_fixes
branch
from
bfb53e1 to
29603fc
Compare
robmry
requested review from
aevesdocker,
craig-osterhout and
sarahsanders-docker
as code owners
github-actions
bot
added
area/compose
github-actions
bot
added
area/guides
area/copilot
area/ai
area/dhi
area/offload
ci
Contributor
Author
|
@dvdksn - we shipped 29.0.0, so this can be reviewed/merged now. (The bonkers list of reviewers and labels came about because I rebased on main, while the PR was still pointing at the moby29 branch.) |
Contributor
|
Looks like the build has hung... |
dvdksn
force-pushed
the
moby29_bug_fixes
branch
from
29603fc to
4a49397
Compare
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dvdksn
approved these changes
Nov 13, 2025
Contributor
dvdksn
left a comment
dvdksn
left a comment
There was a problem hiding this comment.
Looks great, just a minor suggestion for clarity
Comment on lines
294
to
297
| By default, if NAT is enabled for a bridge network, outgoing packets from | ||
| containers are masqueraded. This means the source address of packets | ||
| leaving the Docker host is changed to an address on the host interface | ||
| the packet is sent on. |
Contributor
There was a problem hiding this comment.
Suggested change
| By default, if NAT is enabled for a bridge network, outgoing packets from | |
| containers are masqueraded. This means the source address of packets | |
| leaving the Docker host is changed to an address on the host interface | |
| the packet is sent on. | |
| NAT is enabled by default for bridge networks, meaning outgoing packets | |
| from containers are masqueraded. The source address of packets leaving | |
| the Docker host is changed to an address on the host interface the packet | |
| is sent on. |
Signed-off-by: Rob Murray <[email protected]>
Signed-off-by: Rob Murray <[email protected]>
Signed-off-by: Rob Murray <[email protected]>
robmry
force-pushed
the
moby29_bug_fixes
branch
from
4a49397 to
525496d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
com.docker.network.host_ipv4driver option for bridge networks #22694These changes aren't moby-29 specific - but 29.0 will be ready soon, and the networking docs moved around a bit (so, less chance of conflict confusion this way).