Skip to content

Fix grammar in environment variables section #23620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ahopp wants to merge 2 commits into from
Closed

Fix grammar in environment variables section #23620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ec29b4
fix: correct grammar in environment variables section
Oct 28, 2025
b8d0295
docs: add note about application startup delay
Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion content/get-started/docker-concepts/the-basics/what-is-docker-compose.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ Follow the instructions to run the to-do list app on your system.

If this feels overwhelming, don't worry! You'll get there!

5. With everything now up and running, you can open [http://localhost:3000](http://localhost:3000) in your browser to see the site. Feel free to add items to the list, check them off, and remove them.
5. With everything now up and running, you can open [http://localhost:3000](http://localhost:3000) in your browser to see the site. Note that the application may take 10-15 seconds to fully start. If the page doesn't load right away, wait a moment and refresh. Feel free to add items to the list, check them off, and remove them.

![A screenshot of a webpage showing the todo-list application running on port 3000](images/todo-list-app.webp?border=true&w=950&h=400)

Expand Down
2 changes: 1 addition & 1 deletion data/engine-cli/docker.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ long: |-

### Environment variables

The following list of environment variables are supported by the `docker` command
The following list of environment variables is supported by the `docker` command
Copy link
Contributor

@dvdksn dvdksn Oct 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch but unfortunately this file is generated, from this: https://github.com/docker/cli/blob/master/docs/reference/commandline/docker.md

And reading this just now, maybe we could even clarify what we mean here with:

The following environment variables configure the Docker CLI:

Would you mind submitting a PR to docker/cli and dropping it from here?

Copy link
Contributor Author

@ahopp ahopp Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing now. Thanks.

line:

| Variable | Description |
Expand Down