Fix config save value

Author: colinmcneil

src/extension/ui/src/components/tile/ConfigEditor.tsx

@@ -4,7 +4,7 @@ import { CatalogItemRichened } from "../../types/catalog";
 import { useEffect, useState, useCallback, useMemo } from "react";
 import * as JsonSchema from "json-schema-library";
 import { getTemplateForItem, useConfig } from "../../hooks/useConfig";
-import { deepFlattenObject, deepSet } from "../../MergeDeep";
+import { buildObjectFromFlattenedObject, deepFlattenObject, deepSet } from "../../MergeDeep";
 import { CheckOutlined, CloseOutlined } from "@mui/icons-material";
 import { v1 } from "@docker/extension-api-client-types";
 
@@ -87,7 +87,7 @@ const ConfigEditor = ({ catalogItem, client }: { catalogItem: CatalogItemRichene
                                     <CircularProgress size={24} />
                                 ) : (
                                     <Stack direction="row" spacing={2}>
-                                        <IconButton onClick={() => updateExistingConfig(catalogItem.name, localConfig)}
+                                        <IconButton onClick={() => updateExistingConfig(catalogItem.name, buildObjectFromFlattenedObject(localConfig))}
                                             disabled={isSaving}
                                         >
                                             <CheckOutlined sx={{ color: 'success.main' }} />

src/extension/ui/src/hooks/useCatalog.ts

@@ -34,14 +34,20 @@ export function useCatalog(client: v1.DockerDesktopClient) {
     const enrichCatalogItem = (item: CatalogItemWithName): CatalogItemRichened => {
         const secretsWithAssignment = Secrets.getSecretsWithAssignment(item, secrets || []);
         const itemConfigValue = config?.[item.name] || {};
-        const unConfigured = Boolean(item.config && Object.keys(itemConfigValue).length === 0);
+        const neverOnceConfigured = Boolean(item.config && Object.keys(itemConfigValue).length === 0);
+        const configTemplate = getTemplateForItem(item, itemConfigValue);
+        const baseConfigTemplate = getTemplateForItem(item, {});
+        const unConfigured = neverOnceConfigured || JSON.stringify(itemConfigValue) === JSON.stringify(baseConfigTemplate);
+        if (item.name === 'atlassian') {
+            console.log('atlassian', itemConfigValue, configTemplate, unConfigured)
+        }
         const missingASecret = secretsWithAssignment.some((secret) => !secret.assigned);
         const enrichedItem: CatalogItemRichened = {
             ...item,
             secrets: secretsWithAssignment,
             configValue: itemConfigValue,
             configSchema: item.config,
-            configTemplate: getTemplateForItem(item, itemConfigValue),
+            configTemplate,
             missingConfig: unConfigured,
             missingSecrets: missingASecret,
             registered: !!registryItems?.[item.name],